unable to update enable_snat using router-update command

[Kiran]

Currently enable_snat is allowed only when setting a gateway.

$ neutron router-gateway-set <router-name> <ext-network> --disable-net
$ neutron router-gateway-set <router-name> <ext-network> --enable-net

There should be provision to set this flag with update command too.
Like
$ neutron router-update --enable-snat
$ neutron router-update --disable-snat

On Neutron, with the below command:
curl -g -i -X PUT http://10.0.4.130:9696/v2.0/routers/deecfcf8-6a4d-494d-938e-515f5c9d5885.json -H "User-Agent: python-neutronclient" -H "Content-Type: application/json" -H "Accept: application/json" -H "X-Auth-Token: b964f5aed06147efa06d27392db4f4f4" -d '{"router": {"external_gateway_info": {"enable_snat": false}}}'

Actual Response:
HTTP/1.1 400 Bad Request
Content-Length: 234
Content-Type: application/json; charset=UTF-8
X-Openstack-Request-Id: req-ac54539c-74eb-4fc1-8eac-339c928c69a6
Date: Wed, 07 Sep 2016 08:31:22 GMT

{"NeutronError": {"message": "Invalid input for external_gateway_info. Reason: Validation of dictionary's keys failed. Expected keys: set(['network_id']) Provided keys: set([u'enable_snat'])."

Expected Response : That the external_gateway_info would have the SNAT disabled, even without the gateway network ID

In Other words,
Expectation is that user can be allowed to enable/disable SNAT independently if the External Gateway Network ID is set. If not,
then it should be avoided

[Ihar Hrachyshka (ihar-hrachyshka)]

There is workaround, so setting Low priority.

[Armando Migliaccio (armando-migliaccio)]

This bug is > 180 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

[Launchpad Janitor (janitor)]

[Expired for python-neutronclient because there has been no activity for 60 days.]

[Ihar Hrachyshka (ihar-hrachyshka)]

There is some slight value in allowing the new request, it makes api a bit more flexible. Though it's not clear to me how often one needs to set/unset just that flag.

I would say, we could remove 'rfe' tag and track it as a regular bug, as best effort. Maybe even tag the bug as a low-hanging-fruit.

[Kevin Benton (kevinbenton)]

I think this is a reasonable thing to allow to be fixed in the Neutron client. The workaround of clearing the gateway can result in losing the fixed IP to other ongoing requests.

[Armando Migliaccio (armando-migliaccio)]

neutronclient development is frozen. If you want this target the OSC client. I know we still have a pending patch to allow us to set the gateway [1]. So this to me is a WONTFIX.

[1] https://review.openstack.org/#/c/357973/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/405081

[Reedip (reedip-banerjee-deactivatedaccount)]

Since I am not active anymore, I would like to remove myself from the assignee. Its open for anyone else to take up.