"neutron help router-update" missing help info.

[Danny Choi]

nova-manage version: 2014.2.2

Issue: "neutron help router-update" missing the following help info
--name
--admin_state_up

localadmin@qa4:~/devstack$ neutron help router-update
usage: neutron router-update [-h] [--request-format {json,xml}] ROUTER

Update router's information.

positional arguments:
  ROUTER ID or name of router to update.

optional arguments:
  -h, --help show this help message and exit
  --request-format {json,xml}
                        The XML or JSON request format.

<1> User is able to update the name:
=================================
localadmin@qa4:~/devstack$ neutron router-show router1
+-----------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Field | Value |
+-----------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| admin_state_up | True |
| distributed | True |
| external_gateway_info | {"network_id": "15c36dd8-45b5-4304-8fd3-8a81c81b300c", "enable_snat": true, "external_fixed_ips": [{"subnet_id": "5ac3bd1b-c35c-49ab-9129-102ae83027a9", "ip_address": "172.29.173.5"}]} |
| ha | False |
| id | 5f661458-1c1d-4878-b015-402bb2c59253 |
| name | router1 |
| routes | |
| status | ACTIVE |
| tenant_id | 242f2d539f1b4889a66fa6c4b5a5b919 |
+-----------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

localadmin@qa4:~/devstack$ neutron router-update --name=os-router router1
Updated router: router1
localadmin@qa4:~/devstack$ neutron router-list
+--------------------------------------+-----------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------+-------+
| id | name | external_gateway_info | distributed | ha |
+--------------------------------------+-----------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------+-------+
| 5f661458-1c1d-4878-b015-402bb2c59253 | os-router | {"network_id": "15c36dd8-45b5-4304-8fd3-8a81c81b300c", "enable_snat": true, "external_fixed_ips": [{"subnet_id": "5ac3bd1b-c35c-49ab-9129-102ae83027a9", "ip_address": "172.29.173.5"}]} | True | False |
+--------------------------------------+-----------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------+-------+

<2> User is able to update admin_state_up:
==========================================

localadmin@qa4:~/devstack$ neutron router-show os-router
+-----------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Field | Value |
+-----------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| admin_state_up | True |
| distributed | True |
| external_gateway_info | {"network_id": "15c36dd8-45b5-4304-8fd3-8a81c81b300c", "enable_snat": true, "external_fixed_ips": [{"subnet_id": "5ac3bd1b-c35c-49ab-9129-102ae83027a9", "ip_address": "172.29.173.5"}]} |
| ha | False |
| id | 5f661458-1c1d-4878-b015-402bb2c59253 |
| name | os-router |
| routes | |
| status | ACTIVE |
| tenant_id | 242f2d539f1b4889a66fa6c4b5a5b919 |
+-----------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
localadmin@qa4:~/devstack$ neutron router-update --admin_state_up=false os-router
Updated router: os-router
localadmin@qa4:~/devstack$ neutron router-show os-router
+-----------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Field | Value |
+-----------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| admin_state_up | False |
| distributed | True |
| external_gateway_info | {"network_id": "15c36dd8-45b5-4304-8fd3-8a81c81b300c", "enable_snat": true, "external_fixed_ips": [{"subnet_id": "5ac3bd1b-c35c-49ab-9129-102ae83027a9", "ip_address": "172.29.173.5"}]} |
| ha | False |
| id | 5f661458-1c1d-4878-b015-402bb2c59253 |
| name | os-router |
| routes | |
| status | ACTIVE |
| tenant_id | 242f2d539f1b4889a66fa6c4b5a5b919 |
+-----------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

[Ihar Hrachyshka (ihar-hrachyshka)]

Note that we *must* support old (--...=True) style for booleans (and other options). For compatibility reasons. See: https://review.openstack.org/141063

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/145439

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kyle Mestery (<email address hidden>) on branch: master
Review: https://review.openstack.org/145439
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.