Content-Type/Accept headers are no more specified in requests

[Cedric Brandily]

Since keystone V3 auth support merge[1], neutronclient no more specifies Content-Type in requests with body:

  neutron --verbose net-create test
  ...

  DEBUG: keystoneclient.session REQ: curl -i -X POST http://pegsrt12.srv:9696/v2.0/networks.json -H "User-Agent: python- neutronclient" -H "X-Auth-Token: 19507007f4f043ab8e15e519282ade08" -d '{"network": {"name": "c-run", "admin_state_up": true}}'

Such request are invalid but succeed because neutron is able to deduce content-type from the url suffix .json.

[1]https://review.openstack.org/92390

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/121014

[Cedric Brandily (cbrandily)]

Since keystone V3 auth support merge, neutronclient no more specifies Accept header.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/121014
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=fb83043e152e2181ed2431125bba32d89e3908b7
Submitter: Jenkins
Branch: master

commit fb83043e152e2181ed2431125bba32d89e3908b7
Author: Cedric Brandily <email address hidden>
Date: Thu Sep 11 21:14:18 2014 +0200

    Correct Content-Type/Accept management in HTTPClient/SessionClient

    Currently SessionClient.request never specifies Content-Type/Accept
    headers in requests where HTTPClient.request always specifies json
    Content-Type/Accept even with "--request-format xml" option ... requests
    succeed because neutron deduces Content-Type/Accept from url suffix when
    defined.

    This change ensures HTTPClient/SessionClient define Content-Type/Accept
    headers when needed and align them with --request-format option.

    Closes-Bug: #1368335
    Change-Id: I909e055e5e59fa5870a28ebb0f171812acca0745

[Randall Burt (randall-burt)]

Because this only sets the default value for the map, the actual Accept and Content-type headers don't wind up getting sent. I think this bug should be re-opened.

[Cedric Brandily (cbrandily)]

According test_without_body and test_with_body[1], Accept and Content-Type (when needed) are sended.

Could you provide an example?

[1] https://github.com/openstack/python-neutronclient/blob/fb83043e152e2181ed2431125bba32d89e3908b7/neutronclient/tests/unit/test_http.py#L59-L65