Remove validation of enums from client for VPN

[Paul Michali]

The python-neutronclient currently does validation of enum attributes for VPNaaS commands. Although convenient, it prevents the ability of other service providers from specifying different values (more or less) for the enum.

For example, IPSec policy has:

        parser.add_argument(
            '--encryption-algorithm',
            default='aes-128', choices=['3des',
                                        'aes-128',
                                        'aes-192',
                                        'aes-256'],
            help=_('Encryption Algorithm in lowercase, default:aes-128'))

At the summit, the consensus was to remove the validation and allow all validation to be done on the server side (as is done for REST requests).

May need to also modify help messages to be more generic.

This is related to blueprint: l3-svcs-vendor-client-cap

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/99437

[Carl Baldwin (carl-baldwin)]

My proposed change target the excryption-algorithm specifically. I think when that merges, we should close this bug and open another down the road when other similar problems with other fields are identified.

[Paul Michali (pcm)]

The issue seems to be with all enum based fields (so both IKE and IPsec encryption algorithms, along with other attributes).

The question is, do we change those to strings?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/99437
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=b21cafaa219c4a84cb2babd80e284421a761be30
Submitter: Jenkins
Branch: master

commit b21cafaa219c4a84cb2babd80e284421a761be30
Author: Carl Baldwin <email address hidden>
Date: Wed Jun 11 17:35:57 2014 +0000

    Remove strict checking of encryption type

    The server may accept a different set of encryption-algorithm
    dependending on the service plugin that is being used. Without a
    better mechanism for communicating this to the client, we decided at
    the Atlanta summit to just remove it.

    Change-Id: I658fe00281e9cbd018095969d80f5c09aca6cd38
    Closes-Bug: #1322659