quantumclient unit test: Declare less variables when possible

[Avishay Balderman]

In quantumclient/tests/unit/lb/test_cli20_pool.py (as an example) we have the following code:
def test_create_pool_with_mandatory_params(self):
        """lb-pool-create with mandatory params only"""
        resource = 'pool'
        cmd = pool.CreatePool(test_cli20.MyApp(sys.stdout), None)
        name = 'my-name'
        lb_method = 'round-robin'
        protocol = 'http'
        subnet_id = 'subnet-id'
        tenant_id = 'my-tenant'
        my_id = 'my-id'
        args = ['--lb-method', lb_method,
                '--name', name,
                '--protocol', protocol,
                '--subnet-id', subnet_id,
                '--tenant-id', tenant_id]
        position_names = ['admin_state_up', 'lb_method', 'name',
                          'protocol', 'subnet_id', 'tenant_id']
        position_values = [True, lb_method, name,
                           protocol, subnet_id, tenant_id]
        self._test_create_resource(resource, cmd, name, my_id, args,
                                   position_names, position_values)

 -- This is a pattern in the load balancing tests in quantumclient. --
The proposal below will cover the 'simple' cases and might need some modifications in other cases

We are able to implement this code in a more "economic" way. The main point us to define 'args' as dict and derive rest of the data we need from this dict.

A working example below.
-----------------------------
def create_args(args):
    position_names = args.keys()
    position_values = args.values()
    args_list = []
    for k,v in args.iteritems():
        args_list.append("--" + k)
        args_list.append(v)
    return position_names, position_values, args_list
def main():
    args = {}
    args["name"] = "my-name"
    args["description"] = "my-description"
    args["address"] = "10.0.0.2"
    args["admin_state"] = False
    args["connection_limit"] = 1000
    args["port"] = 80
    args["subnet_id"] = "subnet_id"
    args["tenant_id"] = "my-tenant"
    position_names, position_values, args_list = create_args(args)
    print position_names
    print position_values
    print args_list
if __name__ == "__main__":
    main()

[Maru Newby (maru)]

Please refine the description of this bug to be more specific to the problem being addressed.

Also, if args is going to be defined as a dict, consider defining it in one step for brevity, e.g.:

args = dict(
  name='my-name',
  description='my-description',
  ...
  )

[Mark McClain (markmcclain)]

Moving to client project since this bug applies there.

[Akihiro Motoki (amotoki)]

It is not specific to LBaaS v1 test. This pattern is used everywhere in neutronclient.
It should be cleanup once.

BTW, neutronclient uses mox as the test framework.
If we do migration to mock, it may be a good chance to refactor this kind tests.

[Akihiro Motoki (amotoki)]

There is no activity for a long time, so I will mark it as Incomplete.

[Launchpad Janitor (janitor)]

[Expired for python-neutronclient because there has been no activity for 60 days.]