When importing dependencies client doesn't preserve order of requirement of packages

Bug #1585420 reported by Kirill Zaitsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-muranoclient
Fix Released
High
Valerii Kovalchuk

Bug Description

When importing package dependencies client imports them at random, not keeping the order of the packages.

Expected result: the top-most package (the one at the top of the requirements tree) is imported first, then all the packages that require it are imported, and so on

summary: - When importing dependencies client doesn't preserve inheritance order
+ When importing dependencies client doesn't preserve order of requirement
+ of packages
Changed in python-muranoclient:
assignee: nobody → Valerii Kovalchuk (vakovalchuk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/321069

Changed in python-muranoclient:
status: Confirmed → In Progress
Changed in python-muranoclient:
assignee: Valerii Kovalchuk (vakovalchuk) → Konstantin (ksnihyr)
Changed in python-muranoclient:
assignee: Konstantin (ksnihyr) → Valerii Kovalchuk (vakovalchuk)
Changed in python-muranoclient:
assignee: Valerii Kovalchuk (vakovalchuk) → Konstantin (ksnihyr)
Changed in python-muranoclient:
assignee: Konstantin (ksnihyr) → Valerii Kovalchuk (vakovalchuk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/321069
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=a4c351cb47675459200707549d278cc967bd21c6
Submitter: Jenkins
Branch: master

commit a4c351cb47675459200707549d278cc967bd21c6
Author: Valerii Kovalchuk <email address hidden>
Date: Wed May 25 18:18:40 2016 +0300

    Import package and dependencies in correct order

    Package and its dependencies are being imported in random
    order which allows to import package and then get an error while
    importing its dependency.
    This patch uses OrderedDict ordered by topological sort instead
    of regular dict to fix that.
    Cyclic requirements are imported in random order.
    Tests to check order of import are also added.

    Change-Id: Ia6cb087679b3ae4613ac3d1d19279a9826e537ef
    Closes-bug: #1585420
    Co-Authored-By: ksnihyr <email address hidden>

Changed in python-muranoclient:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-muranoclient 0.9.0

This issue was fixed in the openstack/python-muranoclient 0.9.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.