python-muranoclient

Package import fails with "Invalid FullName"

Bug #1469174 reported by Marc Koderer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-muranoclient
Fix Released
Medium
Dmytro Dovbii
python-muranoclient 0.6.3

Bug Description

Package full name is a mandatory parameter in package-import but optional in package-create.

Steps to reproduce:
-----------------------------

 murano package-create -t example-cloud-init.yaml -o t1000
 murano package-import t1000

Importing package io.murano.apps.generated.Example-Cloud-Init
Error <html>
 <head>
  <title>400 Bad Request</title>
 </head>
 <body>
  <h1>400 Bad Request</h1>
  Couldn't load package from file: Incorrect package format: Invalid FullName<br /><br />

 </body>
</html>

Tags: cli
Revision history for this message
Ekaterina Chernova (efedorova) wrote :

It's optional indeed. It generates automatically from heat-template name.

But in particular name '-' sign is presented and murano package name should not contain this symbol.

Try to change name in your template to avoid this problem

In client, we probably need to check for valid regexp and give a correct error.

tags: added: cli
Changed in murano:
status: New → Invalid
status: Invalid → Won't Fix
status: Won't Fix → Confirmed
affects: murano → python-muranoclient
Changed in python-muranoclient:
milestone: none → 0.6.1
importance: Undecided → Medium
takayuki (tkyk-mitsui)
Changed in python-muranoclient:
assignee: nobody → takayuki (tkyk-mitsui)
Serg Melikyan (smelikyan)
Changed in python-muranoclient:
milestone: 0.6.1.0 → next
Revision history for this message
Dmytro Dovbii (ddovbii) wrote :

@takayuki, hi!
What is the status of your fixing?
Looks like I've accidently fixed this bug in first patch of commit https://review.openstack.org/#/c/204048/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/211654

Changed in python-muranoclient:
assignee: takayuki (tkyk-mitsui) → Dmytro Dovbii (ddovbii)
status: Confirmed → In Progress
Revision history for this message
Dmytro Dovbii (ddovbii) wrote :

Fix proposed: https://review.openstack.org/#/c/211654/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/211654
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=0844f0158f56ad6999992f50bebc510f50df2f4b
Submitter: Jenkins
Branch: master

commit 0844f0158f56ad6999992f50bebc510f50df2f4b
Author: Dmytro Dovbii <email address hidden>
Date: Tue Aug 11 19:18:46 2015 +0300

    Add check for dashes in template name

    Added filter for '-' sign in hot packages name since classes with
    that name is not appropriate and won't be uploaded

    Change-Id: Ic167909cb25afe79bbdff80f5ad8a9cd761e4023
    Closes-Bug: #1469174

Changed in python-muranoclient:
status: In Progress → Fix Committed
Serg Melikyan (smelikyan)
Changed in python-muranoclient:
milestone: next → 0.6.3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.