muranoclient package upload doesn't use resource manager

Bug #1354129 reported by Steve McLellan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-muranoclient
Fix Released
High
Andrew Pashkin

Bug Description

In python-muranoclient/blob/master/muranoclient/v1/packages.py:L53 (package create), a call is made directly to requests, bypassing self.api (which is the common/http module). In itself this would be ok, but it means that it skips any logging that happens. The reason for it being this way i think is that it's using multipart uploads, which are not part of what the http module copes with. Suggest waiting til after the change to use Requests lands, and adding a function to common.http.HttpClient to accept multipart uploads.

ruhe (ruhe)
affects: murano → python-muranoclient
Changed in python-muranoclient:
status: New → Confirmed
milestone: none → 0.5.6
Changed in python-muranoclient:
assignee: nobody → Andrew Pashkin (apashkin)
status: Confirmed → In Progress
Changed in python-muranoclient:
status: In Progress → Fix Committed
Changed in python-muranoclient:
status: Fix Committed → In Progress
importance: Low → High
Revision history for this message
Andrew Pashkin (apashkin) wrote :
Changed in python-muranoclient:
status: In Progress → Fix Committed
Changed in python-muranoclient:
status: Fix Committed → In Progress
Changed in python-muranoclient:
status: In Progress → Fix Committed
Changed in python-muranoclient:
status: Fix Committed → Fix Released
tags: added: juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-muranoclient (master)

Change abandoned by Ekaterina Chernova (<email address hidden>) on branch: master
Review: https://review.openstack.org/161205
Reason: Other change https://review.openstack.org/#/c/141867/ is merged

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239413

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/239413
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=c60feee45cfa19522075cb0c824450eab514d23a
Submitter: Jenkins
Branch: master

commit c60feee45cfa19522075cb0c824450eab514d23a
Author: Nikolay Starodubtsev <email address hidden>
Date: Mon Oct 26 14:56:14 2015 +0300

    Add keystone v3 support to client

    All clients should support keystone v3 till kilo. This patch adds
    support for keystone sessions, keystone endpoint discovery and support
    for the CLI to provide keystone v3 options. Also, bumped glance client
    API version to 2 for the compatibility with v3 keystone API.

    Change-Id: I565927db7f393c0bae41ebf9c03488f9cd966e79
    Co-Authored-By: David Hu <email address hidden>
    Co-Authored-By: Steve McLellan <email address hidden>
    Closes-Bug: #1354129
    Closes-Bug: #1507932
    Implements: blueprint support-keystone-v3

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.