variable name is highighted on LHS of equality (==) test, but shouldn't be

[Andrew Uzilov]

This pertains to the lp:python-mode branch, I think this bug does not occur in 6.0.2.

LHS of equality (==) tests now gets highlighted, but it shouldn't. The highlighting should only be for LHS on assignment (=) expressions. For example:

if someVar == 5:
     doSomething()

"someVar" is highlighted. However, if you wrap it with something, like this:

if len (someVar) == 5:
     doSomething()

"someVar" is not highlighted.

[Andrew Uzilov (andrew-uzilov)]

Oh, and this bug may have been introduced after Bug 856833 got fixed, but I am not quite sure.

[Andreas Roehler (a-roehler)]

Hi Andrew,

issued a poll at the mailing list, as being not sure what to implement.

Would you consider highlighting it in all circumstances a progress?

Cheers,

Andreas

[Andrew Uzilov (andrew-uzilov)]

Hi Andreas....

OK, I posted my comments on the mailing list, hopefully they are
helpful. If not, please let me know what I can clarify. I'll keep an
eye on the thread.

http://mail.python.org/pipermail/python-mode/2011-September/001243.html

Cheers,
Andrew U.

On Sun, Sep 25, 2011 at 9:50 AM, Andreas Roehler
<email address hidden> wrote:
> Hi Andrew,
>
> issued a poll at the mailing list, as being not sure what to implement.
>
> Would you consider highlighting it in all circumstances a progress?
>
> Cheers,
>
> Andreas
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/858304
>
> Title:
>  variable name is highighted on LHS of equality (==) test, but
>  shouldn't be
>
> Status in An Emacs mode for editing Python code:
>  In Progress
>
> Bug description:
>  This pertains to the lp:python-mode branch, I think this bug does not
>  occur in 6.0.2.
>
>  LHS of equality (==) tests now gets highlighted, but it shouldn't.
>  The highlighting should only be for LHS on assignment (=) expressions.
>  For example:
>
>  if someVar == 5:
>       doSomething()
>
>  "someVar" is highlighted.  However, if you wrap it with something,
>  like this:
>
>  if len (someVar) == 5:
>       doSomething()
>
>  "someVar" is not highlighted.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/python-mode/+bug/858304/+subscriptions
>

[Andreas Roehler (a-roehler)]

Hi,

checked in a change.

Does it work for you?
Please re-open if not.

Cheers,

Andreas