py-execute-region maintains indent making making it impossible to execute indented code

[Gennady N. Uraltsev]

Consider this file:

#! /usr/bin/env python2.7
import os

if __name__ == "__main__":
    print "hello"

selecting the line
>print "hello"

and running py-execute-region

results in this error:

>>> ## executing temporary file /tmp/Python2.728520nnd.py...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/Python2.728520nnd.py", line 3
    print "hello"
    ^
IndentationError: unexpected indent

Apparently py-execute-region maintains indentation and so this makes any indented code not executable by this means.
1)Is this meant this way or maybe py-indent-region should outdent as far as possible for the region selected?
2)Maybe py-execute-region could read a C-u supplied argument about how many indent positions to do when sending to python interpreter.

Thanks!

[Andreas Roehler (a-roehler)]

checked in a fix,

could you try again?

Thanks,

Andreas

[Gennady N. Uraltsev (gennady-uraltsev)]

Dear Andreas,

I have looked at the latest development version and the bug is still there... At least for me..

The same file above, selecting the line with

    print "hello"

and executing the region gives the exact same region

[Gennady N. Uraltsev (gennady-uraltsev)]

Sorry I meant "same region" ----> same python interpreter error.

[Andreas Roehler (a-roehler)]

Am 30.08.2011 20:40, schrieb Gennady N. Uraltsev:
> Dear Andreas,
>
> I have looked at the latest development version and the bug is still
> there... At least for me..
>
> The same file above, selecting the line with
>
> print "hello"
>
> and executing the region gives the exact same region
>

Hmm, think you can't send the line to the python interpreter in this
case. As the indent until "print" raises an error - correctly IMHO.

Sending a region beginning at "print" should work.

BTW py-execute-statement should DTRT and being fastest in these cases.

Cheers,

Andreas

[Georg Brandl (gbrandl)]

How complicated would it be to remove all indentation common to all lines before sending to the interpreter?

[Gennady N. Uraltsev (gennady-uraltsev)]

I agree. Some time ago I used this feature (I cannot recall, maybe it was in python.el or an old verison of python-mode) to prototype code in a very quick way, possibly from inside function definitions etc.... What do you think about it? Maybe implementing it as a behaviour selected by C-u?

[Barry Warsaw (barry)]

I could have sworn py-execute-region inserted a preceding line such as

if True:

when the region to execute was indented. Shouldn't that be enough to avoid indentation errors?

[Andreas Roehler (a-roehler)]

Am 30.08.2011 22:04, schrieb Barry Warsaw:
> I could have sworn py-execute-region inserted a preceding line such as
>
> if True:
>

think you would swear righteously :)

> when the region to execute was indented. Shouldn't that be enough to
> avoid indentation errors?
>

Didn't like that "needs if", as it will work in some, maybe most cases,
but fail in others.

It only deals with a possible one-step indent, but fails with more
indents AFAIU.

Will re-install it the way, it removes all indent from the first line,
dedenting the remaining accordingly.

Cheers,

Andreas

[Barry Warsaw (barry)]

On Aug 31, 2011, at 05:48 AM, Andreas Roehler wrote:

>Am 30.08.2011 22:04, schrieb Barry Warsaw:
>> I could have sworn py-execute-region inserted a preceding line such as
>>
>> if True:
>>
>
>think you would swear righteously :)

No question, it's a hack... but one that's pretty much guaranteed to work. :)

>> when the region to execute was indented. Shouldn't that be enough to
>> avoid indentation errors?
>
>Didn't like that "needs if", as it will work in some, maybe most cases,
>but fail in others.
>
>It only deals with a possible one-step indent, but fails with more
>indents AFAIU.

Actually, no, it should always work. Python only cares that the indentation
is consistent within a block. E.g. this is perfectly valid:

-----snip snip-----
if True:
                             print 'hello world'
-----snip snip-----

[Andreas Roehler (a-roehler)]

Am 31.08.2011 15:22, schrieb Barry Warsaw:
> On Aug 31, 2011, at 05:48 AM, Andreas Roehler wrote:
>
>> Am 30.08.2011 22:04, schrieb Barry Warsaw:
>>> I could have sworn py-execute-region inserted a preceding line such as
>>>
>>> if True:
>>>
>>
>> think you would swear righteously :)
>
> No question, it's a hack... but one that's pretty much guaranteed to
> work. :)
>
>>> when the region to execute was indented. Shouldn't that be enough to
>>> avoid indentation errors?
>>
>> Didn't like that "needs if", as it will work in some, maybe most cases,
>> but fail in others.
>>
>> It only deals with a possible one-step indent, but fails with more
>> indents AFAIU.
>
> Actually, no, it should always work. Python only cares that the indentation
> is consistent within a block. E.g. this is perfectly valid:
>
> -----snip snip-----
> if True:
> print 'hello world'
> -----snip snip-----
>

Ah, thanks, so my arguments shrink a little bit :)

remains saying: when implementing a left-shift of the code delivered
it's more obvious whats on.

[Andreas Roehler (a-roehler)]

Hi Gennady,

could you try again?

Thanks,

Andreas

[Gennady N. Uraltsev (gennady-uraltsev)]

Sorry for the delay.

Works perfectly now!