py-shell-manage-windows works poorly under horizontal window splitting

[J D]

in py-shell-manage windows, the following bit of code executes if there's an exception:

        ((and (boundp 'err-p) err-p)
          (message "hello")
         (py-restore-window-configuration)
         (py-jump-to-exception err-p py-exception-buffer)
         ;; (goto-char (point-max))
         (and (window-full-height-p)
              (funcall py-split-windows-on-execute-function))

This works as expected if windows are split vertically - if the window is already split, the window size is not full-height, and the split window function is not called. However, if the windows are split horizontally, this will continually call the py-split-windows-on-execute-function command every time the file is run, instead of re-using the same window for exceptions. Furthermore, it doesn't respect the py-split-windows-on-execute-p setting.

a proposed fix would be to check the current value of py-split-windows-on-execute-function, and use either window width or window height as appropriate.

[Andreas Roehler (a-roehler)]

Am 29.01.2014 02:01, schrieb J D:
> Public bug reported:
>
> in py-shell-manage windows, the following bit of code executes if
> there's an exception:
>
> ((and (boundp 'err-p) err-p)
> (message "hello")
> (py-restore-window-configuration)
> (py-jump-to-exception err-p py-exception-buffer)
> ;; (goto-char (point-max))
> (and (window-full-height-p)
> (funcall py-split-windows-on-execute-function))
>
> This works as expected if windows are split vertically - if the window
> is already split, the window size is not full-height, and the split
> window function is not called. However, if the windows are split
> horizontally, this will continually call the py-split-windows-on-
> execute-function command every time the file is run, instead of re-using
> the same window for exceptions.

  (one-window-p t) at this plase should do the trick.
Will check a fix.

   Furthermore, it doesn't respect the py-
> split-windows-on-execute-p setting.

This is an error-display, so this setting will be ignored anyway here.

>
> a proposed fix would be to check the current value of py-split-windows-
> on-execute-function, and use either window width or window height as
> appropriate.
>
> ** Affects: python-mode
> Importance: Undecided
> Status: New
>

[Andreas Roehler (a-roehler)]

Checked in a fix. Please tell if it works for you.

[J D (james-davidheiser)]

This fix worked for me - thanks!