Activity log for bug #1191225

Date Who What changed Old value New value Message
2013-06-15 07:00:51 Andreas Roehler bug added bug
2013-06-15 07:01:03 Andreas Roehler python-mode: milestone 6.1.2
2013-06-15 07:01:09 Andreas Roehler python-mode: assignee Andreas Roehler (a-roehler)
2013-06-15 07:01:13 Andreas Roehler python-mode: importance Undecided Medium
2013-06-15 07:04:11 Andreas Roehler summary parens span multiple lines Parens span multiple lines
2013-06-15 07:09:35 Andreas Roehler description On Jun 14, 2013, at 05:04 PM, Felipe Reyes wrote: > >> Hi All, >> >> On Fri, Jun 14, 2013 at 04:30:16PM -0400, Barry Warsaw wrote: >>> It's bad form to use parentheses in this situation, but it *is* legal. It >>> doesn't bother me if python-mode passive/aggressively discourage such bad >>> form, but others might disagree. OTOH, this, which is perfectly fine form, >>> seems to work well: >>> >>> def foo(): >>> if (foo && >>> baz): >>> bar() >>> >>> (i.e. parens used to span multiple lines.) >> >> This example raises a pep8 warning[0], > > Note that PEP 8 doesn't really recommend against this. There's even an > example in the Maximum Line Length section that has this very "problem". > > It's also true that there's no single convention or recommendation for dealing > with this. > >> I've been dealing with it and manually >> adding another indentation level to not leave 'baz' aligned with 'baz()' >> >> def foo(): >> if (foo && >> baz): >> bar() >> >> Can this be considered a bug? > > I think python-mode should be able to handle it, but it needs to be > configurable. > > -Barry > > > On Jun 14, 2013, at 05:04 PM, Felipe Reyes wrote: > >> Hi All, >> >> On Fri, Jun 14, 2013 at 04:30:16PM -0400, Barry Warsaw wrote: >>> It's bad form to use parentheses in this situation, but it *is* legal. It >>> doesn't bother me if python-mode passive/aggressively discourage such bad >>> form, but others might disagree. OTOH, this, which is perfectly fine form, >>> seems to work well: >>> >>> def foo(): >>> if (foo && >>> baz): >>> bar() >>> >>> (i.e. parens used to span multiple lines.) >> >> This example raises a pep8 warning[0], > > Note that PEP 8 doesn't really recommend against this. There's even an > example in the Maximum Line Length section that has this very "problem". > > It's also true that there's no single convention or recommendation for dealing > with this. > >> I've been dealing with it and manually >> adding another indentation level to not leave 'baz' aligned with 'baz()' >> def foo(): if (foo && baz): bar() >> Can this be considered a bug? > > I think python-mode should be able to handle it, but it needs to be > configurable. > > -Barry > > >
2013-06-15 07:10:08 Andreas Roehler description On Jun 14, 2013, at 05:04 PM, Felipe Reyes wrote: > >> Hi All, >> >> On Fri, Jun 14, 2013 at 04:30:16PM -0400, Barry Warsaw wrote: >>> It's bad form to use parentheses in this situation, but it *is* legal. It >>> doesn't bother me if python-mode passive/aggressively discourage such bad >>> form, but others might disagree. OTOH, this, which is perfectly fine form, >>> seems to work well: >>> >>> def foo(): >>> if (foo && >>> baz): >>> bar() >>> >>> (i.e. parens used to span multiple lines.) >> >> This example raises a pep8 warning[0], > > Note that PEP 8 doesn't really recommend against this. There's even an > example in the Maximum Line Length section that has this very "problem". > > It's also true that there's no single convention or recommendation for dealing > with this. > >> I've been dealing with it and manually >> adding another indentation level to not leave 'baz' aligned with 'baz()' >> def foo(): if (foo && baz): bar() >> Can this be considered a bug? > > I think python-mode should be able to handle it, but it needs to be > configurable. > > -Barry > > > On Jun 14, 2013, at 05:04 PM, Felipe Reyes wrote: > >> Hi All, >> >> On Fri, Jun 14, 2013 at 04:30:16PM -0400, Barry Warsaw wrote: >>> It's bad form to use parentheses in this situation, but it *is* legal. It >>> doesn't bother me if python-mode passive/aggressively discourage such bad >>> form, but others might disagree. OTOH, this, which is perfectly fine form, >>> seems to work well: >>> def foo(): if (foo && baz): bar() >>> >>> (i.e. parens used to span multiple lines.) >> >> This example raises a pep8 warning[0], > > Note that PEP 8 doesn't really recommend against this. There's even an > example in the Maximum Line Length section that has this very "problem". > > It's also true that there's no single convention or recommendation for dealing > with this. > >> I've been dealing with it and manually >> adding another indentation level to not leave 'baz' aligned with 'baz()' >>  def foo():      if (foo &&              baz):          bar() >> Can this be considered a bug? > > I think python-mode should be able to handle it, but it needs to be > configurable. > > -Barry > > >
2013-06-17 14:55:34 Launchpad Janitor branch linked lp:python-mode
2013-06-17 14:55:48 Launchpad Janitor branch linked lp:python-mode/components-python-mode
2013-06-17 15:36:57 Andreas Roehler python-mode: status New Fix Committed
2013-09-03 19:21:53 Andreas Roehler python-mode: status Fix Committed Fix Released