--os-interface option doesn't work

[takahara.kengo]

[Environment]
The endpoint of masakari is set only for internal.
$ openstack endpoint list | grep "masakari"
| f271ebbb17534a19a8e174ed23db4eb0 | RegionOne | masakari | instance-ha | True | internal | http://192.168.10.20:15868/v1/ |

[Bug]
An error occurred when I executed segment list command with --os-interface option.

$ openstack --os-interface internal segment list
public endpoint for instance-ha service not found
$

The command was trying to access to the public endpoint even though it was specified "--os-interface internal" as an option.
But it should access to the internal endpoint.

And, masakari command doesn't implement the --os-interface.
So I think that it should be implemented as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/562974

[takahara.kengo (takahara.kengo)]

I posted patches on both the master and stable/queens branch.

master:
https://review.openstack.org/#/c/562973/

stable/queens:
https://review.openstack.org/#/c/562974/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/599971

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/562973
Committed: https://git.openstack.org/cgit/openstack/python-masakariclient/commit/?id=8b6d55ff01bc73df0ff8355d9db73762222c00b5
Submitter: Zuul
Branch: master

commit 8b6d55ff01bc73df0ff8355d9db73762222c00b5
Author: Kengo Takahara <email address hidden>
Date: Fri Apr 20 16:39:22 2018 +0900

    Add --os-interface and --os-region-name options

    Added --os-region-name option so that operator can run masakari
    commands against multiple regions. By default, keystoneauth always
    tries to connect to the 'public' interface of endpoint so added
    --os-interface option as well as in most cases, operator will configure
    only "internal" interface.

    Co-Author: tpatil <email address hidden>
    Change-Id: I7194ed62d3df9760af61a505a43239097549f3d2
    Closes-Bug: #1764931

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/599971
Committed: https://git.openstack.org/cgit/openstack/python-masakariclient/commit/?id=8c121868027fd4e44712a1673f6b835c2469f1a5
Submitter: Zuul
Branch: stable/rocky

commit 8c121868027fd4e44712a1673f6b835c2469f1a5
Author: Kengo Takahara <email address hidden>
Date: Fri Apr 20 16:39:22 2018 +0900

    Add --os-interface and --os-region-name options

    Added --os-region-name option so that operator can run masakari
    commands against multiple regions. By default, keystoneauth always
    tries to connect to the 'public' interface of endpoint so added
    --os-interface option as well as in most cases, operator will configure
    only "internal" interface.

    Co-Author: tpatil <email address hidden>
    Change-Id: I7194ed62d3df9760af61a505a43239097549f3d2
    Closes-Bug: #1764931

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/masakari-monitors 7.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-masakariclient 5.3.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Radosław Piliszek (<email address hidden>) on branch: stable/queens
Review: https://review.opendev.org/562974
Reason: very old; branch long unmaintained

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/masakari-monitors rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-masakariclient rocky-eol release.