python-masakariclient

Need to improve unittests

Bug #1668886 reported by Rohanil Raje
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-masakariclient
Fix Released
Low
takahara.kengo

Bug Description

Most of unit tests are not testing functional properties. Like TestV1DeleteHost is not testing DeleteHost class directly, there is not any assertion. So even if there is small change in DeleteHost class, the change is not tested properly in tests.

takahara.kengo (takahara.kengo)
Changed in python-masakariclient:
assignee: nobody → takahara.kengo (takahara.kengo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-masakariclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/440999

Changed in python-masakariclient:
status: New → In Progress
SamP (sampath-priyankara)
Changed in python-masakariclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-masakariclient (master)

Reviewed: https://review.openstack.org/440999
Committed: https://git.openstack.org/cgit/openstack/python-masakariclient/commit/?id=445aab9cdb8d4480c342b6c4a3a8690f867dcbc6
Submitter: Jenkins
Branch: master

commit 445aab9cdb8d4480c342b6c4a3a8690f867dcbc6
Author: Kengo Takahara <email address hidden>
Date: Mon Jun 19 14:36:03 2017 +0900

    Add assertions to UT code

    There are test cases in which there is no assertion in the UT code.
    In that test case, the proper test has not been done.
    This patch adds assertions to the test cases to test them properly.

    Change-Id: Idb7c602e3c73908ad04c587a2e3eb53b0a3e70b2
    Closes-Bug: #1668886

Changed in python-masakariclient:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.