Setting quotas against older API versions fails with `unexpected keyword argument 'per_share_gigabytes'`

[Jan Horstmann]

Setting manila quotas on older installations which do not support `per_share_gigabytes` fails, e.g.:
```
openstack --os-share-api-version 2.57 share quota set --gigabytes X Y
Failed to set quotas for project 'Y' : 'QuotaSetManager.update() got an unexpected keyword argument 'per_share_gigabytes''
```

This is with a current `python-manilaclient`
```
pip freeze | grep manilaclient
python-manilaclient==4.7.0
```

Expected behaviour:
Depending on the share API version `python-manilaclient` should not try to set `per_share_gigabytes`

Please let me know i you need more information to pinpoint the issue.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/906915

[Goutham Pacha Ravi (gouthamr)]

Thanks for the bug report @janhorstmann
Sorry for the delay; we missed this during the holiday season. I've uploaded a fix; it should be fixed, and will be backported to the Bobcat (2023.2) release branch.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/906915
Committed: https://opendev.org/openstack/python-manilaclient/commit/3ec364d1fd1f060a2dbd2c73c17e6ccc55bdcf55
Submitter: "Zuul (22348)"
Branch: master

commit 3ec364d1fd1f060a2dbd2c73c17e6ccc55bdcf55
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Jan 26 11:43:49 2024 -0800

    Fix "per_share_gigabytes" in "openstack quota set"

    The "per_share_gigabytes" quota param was introduced
    in API version 2.62; when using older API versions,
    we shouldn't be setting this parameter.

    Closes-Bug: #2047249
    Change-Id: I1eceee52726cef3494648521e4516010ca02f095

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/907932

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/907933

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/907934

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/907935

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/907932
Committed: https://opendev.org/openstack/python-manilaclient/commit/2614b30db76e77d07c28399aecbedec11e44e3b8
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 2614b30db76e77d07c28399aecbedec11e44e3b8
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Jan 26 11:43:49 2024 -0800

    Fix "per_share_gigabytes" in "openstack quota set"

    The "per_share_gigabytes" quota param was introduced
    in API version 2.62; when using older API versions,
    we shouldn't be setting this parameter.

    Closes-Bug: #2047249
    Change-Id: I1eceee52726cef3494648521e4516010ca02f095
    (cherry picked from commit 3ec364d1fd1f060a2dbd2c73c17e6ccc55bdcf55)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/907933
Committed: https://opendev.org/openstack/python-manilaclient/commit/d2299103938ebebe9887b1699f3357afefc5b2ce
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit d2299103938ebebe9887b1699f3357afefc5b2ce
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Jan 26 11:43:49 2024 -0800

    Fix "per_share_gigabytes" in "openstack quota set"

    The "per_share_gigabytes" quota param was introduced
    in API version 2.62; when using older API versions,
    we shouldn't be setting this parameter.

    Closes-Bug: #2047249
    Change-Id: I1eceee52726cef3494648521e4516010ca02f095
    (cherry picked from commit 3ec364d1fd1f060a2dbd2c73c17e6ccc55bdcf55)
    (cherry picked from commit 2614b30db76e77d07c28399aecbedec11e44e3b8)

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/yoga
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/907935
Reason: stable/yoga branch of openstack/python-manilaclient is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/yoga if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: unmaintained/yoga
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/909552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/907934
Committed: https://opendev.org/openstack/python-manilaclient/commit/4eee3bf60b5285f247b6b3e3a415b21539b582d3
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 4eee3bf60b5285f247b6b3e3a415b21539b582d3
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Jan 26 11:43:49 2024 -0800

    Fix "per_share_gigabytes" in "openstack quota set"

    The "per_share_gigabytes" quota param was introduced
    in API version 2.62; when using older API versions,
    we shouldn't be setting this parameter.

    Closes-Bug: #2047249
    Change-Id: I1eceee52726cef3494648521e4516010ca02f095
    (cherry picked from commit 3ec364d1fd1f060a2dbd2c73c17e6ccc55bdcf55)
    (cherry picked from commit 2614b30db76e77d07c28399aecbedec11e44e3b8)
    (cherry picked from commit d2299103938ebebe9887b1699f3357afefc5b2ce)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient 4.8.0 release.