share-group-type-set command format conversion issue

[Vida Haririan]

Executed the command to set share group type properties,

$ openstack share group type set default --group-specs 'key=12 key=13'

Displayed the new sgt properties,

$ openstack share group type show default

+-------------+--------------------------------------+
| Field | Value |
+-------------+--------------------------------------+
| id | f5238905-ff83-429f-bd78-241fcd9a1f4f |
| name | default |
| share_types | f951a739-0200-45ec-9e43-6ab34d30a567 |
| visibility | public |
| is_default | True |
| group_specs | key : 12 key=13 |
+-------------+--------------------------------------+

Expected the group_specs output 'key=12 key=13'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/842655

[Goutham Pacha Ravi (gouthamr)]

Hi Carlos,

the problem here is in the input... Your group specs are being interpreted as

 key="12 key=13"

So, you're seeing the weird formatting in the output. Further, using "key" twice will cause the second input to win since extra-spec keys need to be unique.

Example:

$ openstack share group type set default --group-specs foo=bar max=tyu

stack@zorilla-cephnfs:~$ openstack share group type show default
+-------------+--------------------------------------+
| Field | Value |
+-------------+--------------------------------------+
| id | 2c90020b-0370-4de4-a6e8-334491b1da8a |
| name | default |
| share_types | 78fcd059-96ed-444a-9492-51689838aa14 |
| visibility | public |
| is_default | True |
| group_specs | max : tyu |
| | foo : bar |
+-------------+--------------------------------------+

[Vida Haririan (vhariria)]

Hi Goutham.. is this intended for me? :)

On Fri, Aug 19, 2022 at 3:21 PM Goutham Pacha Ravi <
<email address hidden>> wrote:

> Hi Carlos,
>
> the problem here is in the input... Your group specs are being
> interpreted as
>
> key="12 key=13"
>
>
> So, you're seeing the weird formatting in the output. Further, using "key"
> twice will cause the second input to win since extra-spec keys need to be
> unique.
>
> Example:
>
> $ openstack share group type set default --group-specs foo=bar max=tyu
>
> stack@zorilla-cephnfs:~$ openstack share group type show default
> +-------------+--------------------------------------+
> | Field | Value |
> +-------------+--------------------------------------+
> | id | 2c90020b-0370-4de4-a6e8-334491b1da8a |
> | name | default |
> | share_types | 78fcd059-96ed-444a-9492-51689838aa14 |
> | visibility | public |
> | is_default | True |
> | group_specs | max : tyu |
> | | foo : bar |
> +-------------+--------------------------------------+
>
> ** Changed in: python-manilaclient
> Status: In Progress => Invalid
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1974238
>
> Title:
> share-group-type-set command format conversion issue
>
> Status in python-manilaclient:
> Invalid
>
> Bug description:
> Executed the command to set share group type properties,
>
> $ openstack share group type set default --group-specs 'key=12 key=13'
>
> Displayed the new sgt properties,
>
> $ openstack share group type show default
>
> +-------------+--------------------------------------+
> | Field | Value |
> +-------------+--------------------------------------+
> | id | f5238905-ff83-429f-bd78-241fcd9a1f4f |
> | name | default |
> | share_types | f951a739-0200-45ec-9e43-6ab34d30a567 |
> | visibility | public |
> | is_default | True |
> | group_specs | key : 12 key=13 |
> +-------------+--------------------------------------+
>
> Expected the group_specs output 'key=12 key=13'
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/python-manilaclient/+bug/1974238/+subscriptions
>
> Launchpad-Notification-Type: bug
> Launchpad-Bug: product=python-manilaclient; status=Invalid;
> importance=Undecided; <email address hidden>;
> Launchpad-Bug-Information-Type: Public
> Launchpad-Bug-Private: no
> Launchpad-Bug-Security-Vulnerability: no
> Launchpad-Bug-Commenters: gouthamr hudson-openstack vhariria
> Launchpad-Bug-Reporter: Vida Haririan (vhariria)
> Launchpad-Bug-Modifier: Goutham Pacha Ravi (gouthamr)
> Launchpad-Message-Rationale: Subscriber
> Launchpad-Message-For: vhariria
>
>

[Goutham Pacha Ravi (gouthamr)]

> Hi Goutham.. is this intended for me? :)

Ah yes; sorry Vida. but yes..