OSC: version discovery missing

[Maurice Escher]

Hi,

I have a manila installation running xena with a max apiversion 2.65.

I installed the client version 3.2.0.

Attempting a "openstack share list" returns the error "Version 2.66 is not supported by the API. Minimum is 2.0 and maximum is 2.65. (HTTP 406)"

I'm used to the manila command, which negotiates the max supported version between client and server. And my expectation is, that this should work the same way for osc:
if no --os-share-api-version (or env OS_SHARE_API_VERSION) is specified, it should default to the highest version that both server and client can support.

E.g. in my example it should make the call with microversion 2.65 (not 2.66).
If I had running wallaby it should make the call with microversion 2.63 etc.

Or is the expectation that I make sure to have a matching client version installed?

BR,
Maurice

[Maurice Escher (maurice-escher)]

see also https://tree.taiga.io/project/gouthampacha-openstack-manila-osc-integration-with-python-manilaclient/us/82

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/874752

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/874752
Committed: https://opendev.org/openstack/python-manilaclient/commit/95763cdb0557aefd165487847d2f82f7fcf978f9
Submitter: "Zuul (22348)"
Branch: master

commit 95763cdb0557aefd165487847d2f82f7fcf978f9
Author: Kiran Pawar <email address hidden>
Date: Tue Feb 21 11:03:51 2023 +0000

    Use suitable api version for OSC.

    In manilaclient i.e. manila commands, if user supplied version is above
    the max version supported by server, manilaclient adjust to max version.
    This was missing in openstack commands which results in failure that
    version is not supported. Fix by discovering most suitable version and
    use it for client creation.

    Closes-bug: #1960490
    Change-Id: I734f6953e8b0266b38f0cb6e1581c4201f2bd676

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/877639

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/877640

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/877639
Committed: https://opendev.org/openstack/python-manilaclient/commit/9204ba6674ac33821911016f8733e9512a4f32f4
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 9204ba6674ac33821911016f8733e9512a4f32f4
Author: Kiran Pawar <email address hidden>
Date: Tue Feb 21 11:03:51 2023 +0000

    Use suitable api version for OSC.

    In manilaclient i.e. manila commands, if user supplied version is above
    the max version supported by server, manilaclient adjust to max version.
    This was missing in openstack commands which results in failure that
    version is not supported. Fix by discovering most suitable version and
    use it for client creation.

    Closes-bug: #1960490
    Change-Id: I734f6953e8b0266b38f0cb6e1581c4201f2bd676
    (cherry picked from commit 95763cdb0557aefd165487847d2f82f7fcf978f9)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/878035

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/878036

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/878037

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/877640
Committed: https://opendev.org/openstack/python-manilaclient/commit/71c78051bbb22257dd40945f3faf541da7acdeb9
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 71c78051bbb22257dd40945f3faf541da7acdeb9
Author: Kiran Pawar <email address hidden>
Date: Tue Feb 21 11:03:51 2023 +0000

    Use suitable api version for OSC.

    In manilaclient i.e. manila commands, if user supplied version is above
    the max version supported by server, manilaclient adjust to max version.
    This was missing in openstack commands which results in failure that
    version is not supported. Fix by discovering most suitable version and
    use it for client creation.

    Closes-bug: #1960490
    Change-Id: I734f6953e8b0266b38f0cb6e1581c4201f2bd676
    (cherry picked from commit 95763cdb0557aefd165487847d2f82f7fcf978f9)
    (cherry picked from commit 9204ba6674ac33821911016f8733e9512a4f32f4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/878035
Committed: https://opendev.org/openstack/python-manilaclient/commit/40e71538005936af275279d0b3936c7cd2961e01
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 40e71538005936af275279d0b3936c7cd2961e01
Author: Kiran Pawar <email address hidden>
Date: Tue Feb 21 11:03:51 2023 +0000

    Use suitable api version for OSC.

    In manilaclient i.e. manila commands, if user supplied version is above
    the max version supported by server, manilaclient adjust to max version.
    This was missing in openstack commands which results in failure that
    version is not supported. Fix by discovering most suitable version and
    use it for client creation.

    Closes-bug: #1960490
    Change-Id: I734f6953e8b0266b38f0cb6e1581c4201f2bd676
    (cherry picked from commit 95763cdb0557aefd165487847d2f82f7fcf978f9)
    (cherry picked from commit 9204ba6674ac33821911016f8733e9512a4f32f4)
    (cherry picked from commit 71c78051bbb22257dd40945f3faf541da7acdeb9)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/878036
Committed: https://opendev.org/openstack/python-manilaclient/commit/135cdf98c3178276346d8b7764f8877111491919
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 135cdf98c3178276346d8b7764f8877111491919
Author: Kiran Pawar <email address hidden>
Date: Tue Feb 21 11:03:51 2023 +0000

    Use suitable api version for OSC.

    In manilaclient i.e. manila commands, if user supplied version is above
    the max version supported by server, manilaclient adjust to max version.
    This was missing in openstack commands which results in failure that
    version is not supported. Fix by discovering most suitable version and
    use it for client creation.

    Closes-bug: #1960490
    Change-Id: I734f6953e8b0266b38f0cb6e1581c4201f2bd676
    (cherry picked from commit 95763cdb0557aefd165487847d2f82f7fcf978f9)
    (cherry picked from commit 9204ba6674ac33821911016f8733e9512a4f32f4)
    (cherry picked from commit 71c78051bbb22257dd40945f3faf541da7acdeb9)
    (cherry picked from commit 82ad5031cbfcdd7a28c999ea9d6999b144c57b24)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient 3.3.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient 4.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient 4.1.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient 3.0.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient 4.5.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/878037
Committed: https://opendev.org/openstack/python-manilaclient/commit/9846fdf68f002b8493c6adb164f7ed6da3228bdd
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9846fdf68f002b8493c6adb164f7ed6da3228bdd
Author: Kiran Pawar <email address hidden>
Date: Tue Feb 21 11:03:51 2023 +0000

    Use suitable api version for OSC.

    In manilaclient i.e. manila commands, if user supplied version is above
    the max version supported by server, manilaclient adjust to max version.
    This was missing in openstack commands which results in failure that
    version is not supported. Fix by discovering most suitable version and
    use it for client creation.

    Closes-bug: #1960490
    Change-Id: I734f6953e8b0266b38f0cb6e1581c4201f2bd676
    (cherry picked from commit 95763cdb0557aefd165487847d2f82f7fcf978f9)
    (cherry picked from commit 9204ba6674ac33821911016f8733e9512a4f32f4)
    (cherry picked from commit 71c78051bbb22257dd40945f3faf541da7acdeb9)
    (cherry picked from commit 82ad5031cbfcdd7a28c999ea9d6999b144c57b24)
    (cherry picked from commit 744c856bf3f382ba686b1d683f545ef6693fa3dd)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient wallaby-eom release.