Add consistency to displaying column headers for OSC list commands

Bug #1945170 reported by Maari Tamm
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-manilaclient
In Progress
Low
Leslie Stevens

Bug Description

We want to always display "pretty" column headers for a list command.
Meaning, the headers are capitalised, contain no underscores and for "id" we use "ID".

We are missing that for share types [1], share type access [2] and share access rules [3].

We also want to make best use of osc_lib utils [4] and refactor our code to not define columns and column headers separately [5][6].

[1] https://github.com/openstack/python-manilaclient/blob/master/manilaclient/osc/v2/share_types.py#L423
[2] https://github.com/openstack/python-manilaclient/blob/master/manilaclient/osc/v2/share_type_access.py#L84
[3] https://github.com/openstack/python-manilaclient/blob/master/manilaclient/osc/v2/share_access_rules.py#L222
[4] https://github.com/openstack/osc-lib/blob/master/osc_lib/utils/__init__.py#L487
[5] https://github.com/openstack/python-manilaclient/blob/master/manilaclient/osc/v2/share.py#L32-L92
[6] https://github.com/openstack/python-manilaclient/blob/master/manilaclient/osc/v2/share_replicas.py#L160-L170

Maari Tamm (maaritamm)
Changed in python-manilaclient:
assignee: nobody → Maari Tamm (maaritamm)
Changed in python-manilaclient:
status: New → In Progress
Changed in python-manilaclient:
importance: Undecided → Low
assignee: Maari Tamm (maaritamm) → nobody
Changed in python-manilaclient:
assignee: nobody → Leslie Stevens (lesliemstevens)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/812226
Committed: https://opendev.org/openstack/python-manilaclient/commit/1e8330468f6b3f2d24de09874e41ad8c85ad520f
Submitter: "Zuul (22348)"
Branch: master

commit 1e8330468f6b3f2d24de09874e41ad8c85ad520f
Author: Leslie Stevens <email address hidden>
Date: Fri Oct 1 19:42:10 2021 +0000

    Fix displaying column headers for OSC list commands

    Add consistency to displaying column headers for the following
    list commands:
    openstack share type list
    openstack share type access list
    openstack share access list

    Partial-Bug: #1945170
    Change-Id: I88b3103696ab2f47b11d6d938193788e69b5a739

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.