[rfe] Consistent logger usage in osc plugin

[Goutham Pacha Ravi]

This issue has very minor end-user impact.

We have an inconsistent declaration and use of the logger in the OSC plugin. Some commands initialize their own logger, examples: [1][2][3] while some others just use a logger initialized at the module level examples: [4][5]. In many places these loggers are unused. We should look to consolidate to one way of doing this, and cleanup the logger initialization if unused.

[1] https://github.com/openstack/python-manilaclient/blob/fd2a00f9b90f780e5a0dd6106850ac8d59aab708/manilaclient/osc/v2/share_types.py#L68
[2] https://github.com/openstack/python-manilaclient/blob/752aeccd4b66a9efeba6801a57aed6d28cb6b8c7/manilaclient/osc/v2/share_access_rules.py#L45
[3] https://github.com/openstack/python-manilaclient/blob/752aeccd4b66a9efeba6801a57aed6d28cb6b8c7/manilaclient/osc/v2/messages.py#L44
[4] https://github.com/openstack/python-manilaclient/blob/53275bec677e2b82768ee7254f45f52bbeb9b423/manilaclient/osc/v2/availability_zones.py#L20
[5] https://github.com/openstack/python-manilaclient/blob/752aeccd4b66a9efeba6801a57aed6d28cb6b8c7/manilaclient/osc/v2/share_type_access.py#L22

[Goutham Pacha Ravi (gouthamr)]

Additional comments: https://meetings.opendev.org/meetings/manila/2021/manila.2021-09-09-15.00.log.html#l-137

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/812215

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/812215
Committed: https://opendev.org/openstack/python-manilaclient/commit/4e73888b2739b087fb1c2f02ee44000485d84e0a
Submitter: "Zuul (22348)"
Branch: master

commit 4e73888b2739b087fb1c2f02ee44000485d84e0a
Author: altanai <email address hidden>
Date: Fri Oct 1 18:38:13 2021 +0000

    Refractor logs

    Optimize usage of logger so that manilla client does not
    import logger library when not needed.

    Closes-Bug: #1940692
    Change-Id: Idcd327c1f4a2d0b56eb8487fcc885e5e744f0289

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient 3.1.0 release.