Remove unnecessary check for args.force in "manila share-group-snapshot-delete"

Bug #1934771 reported by Maari Tamm
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-manilaclient
Fix Released
Low
Celena Michaud

Bug Description

The "--force" flag for "manila share-group-snapshot-delete" command has a default value of "False", so it's never really going to be "None".

Remove the unnecessary check for missing a value [0] and pass "args.force" straight to the call to remove a share group snapshot.

[0] https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py#L5823

Maari Tamm (maaritamm)
Changed in python-manilaclient:
assignee: nobody → Maari Tamm (maaritamm)
Maari Tamm (maaritamm)
description: updated
Changed in python-manilaclient:
assignee: Maari Tamm (maaritamm) → Kafilat Adeleke (kafilat-adeleke)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)
Changed in python-manilaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/812186
Committed: https://opendev.org/openstack/python-manilaclient/commit/ea9b04f9dff51e54a0691cc1ccffc0efec2784aa
Submitter: "Zuul (22348)"
Branch: master

commit ea9b04f9dff51e54a0691cc1ccffc0efec2784aa
Author: celenamichaud <email address hidden>
Date: Fri Oct 1 18:31:57 2021 +0000

    Remove check for args.force

    Force flag will never be "none", so unnecessary check was removed

    Closes-bug: #1934771
    Change-Id: I1f7a60146a08183c1d208c431e562836a2a9fd19

Changed in python-manilaclient:
status: In Progress → Fix Released
Changed in python-manilaclient:
importance: Undecided → Low
milestone: none → yoga-1
assignee: Kafilat Adeleke (kafilat-adeleke) → Celena Michaud (celenamichaud)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 3.1.0

This issue was fixed in the openstack/python-manilaclient 3.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.