Share replica create API does not allow to specify share network

[Maurice Escher]

Hi,

I wanted to use share replication with DHSS=true and let my replica be created in a different share network.

I've seen that the feature was there in the past, but has been removed via https://bugs.launchpad.net/manila/+bug/1588144 - at that time replication did not work with DHSS=true, but this is different now.

Use cases are:
1. customer (non-admin) driven migration from one share network to another share network via replication
2. network setup that has different neutron networks per availability zone (and therefore different) share networks and also wants to have replication setup between those two zones

Please bring the share network parameter back!

Best,
Maurice

[Maurice Escher (maurice-escher)]

Additional thoughts: the current api-ref makes the impression I could use this parameter with the pre 2.51 API microversion, but this is not the case - it is not hidden behind an older microversion, instead it is gone.

[Vida Haririan (vhariria)]

Additional comments http://eavesdrop.openstack.org/meetings/manila/2021/manila.2021-04-29-15.00.log.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/804578

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/804589

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/804578
Committed: https://opendev.org/openstack/manila/commit/b49605945a8e58ea33abfd559d9b87a6507519ab
Submitter: "Zuul (22348)"
Branch: master

commit b49605945a8e58ea33abfd559d9b87a6507519ab
Author: kpdev <email address hidden>
Date: Sat Aug 14 19:38:55 2021 +0200

    Add "share-network" option for replica create API.

    Share replica create API does not allow to specify share network and
    forces to use parent share's share network. This is problem for some
    use-cases, e.g. migration from one share network to another share
    network via replication is not possible. Fixed by allowing to pass
    'share-network' option for share replica create API and make sure both
    parent share-network and user provided share-network will have same
    security service association.

    Partial-Bug: #1925486
    Change-Id: I9049dcd418fbb16d663ab8ed27b90c765fafc5d3

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/855123

[Carlos Eduardo (silvacarlose)]

https://review.opendev.org/c/openstack/manila/+/804578 - This commit fixed this issue. The current open one is fixing follow-up suggestions.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/855123
Committed: https://opendev.org/openstack/manila/commit/ba5455cbd6d52e1b128bbbbfddb5a3cd57dcda50
Submitter: "Zuul (22348)"
Branch: master

commit ba5455cbd6d52e1b128bbbbfddb5a3cd57dcda50
Author: Kiran Pawar <email address hidden>
Date: Tue Aug 30 08:10:24 2022 +0000

    Fix tests for 'share-network' param in share replica create

    Fix suggestions from
    https://review.opendev.org/c/openstack/manila/+/804578

    Closes-Bug: #1925486
    Change-Id: I92d5ed80fb659526dff795cf474826bed45a1d19

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/804589
Committed: https://opendev.org/openstack/manila-tempest-plugin/commit/2521fbf86a2aa001e5c82dc9fd36d39646b37a3b
Submitter: "Zuul (22348)"
Branch: master

commit 2521fbf86a2aa001e5c82dc9fd36d39646b37a3b
Author: kpdev <email address hidden>
Date: Sun Aug 15 21:54:41 2021 +0200

    Add tests replica create with 'share-network' option.

    This patch update positive and negative tests using the
    share replica create API. For version >= 2.72.

    Partial-Bug: #1925486
    Depends-On: I9049dcd418fbb16d663ab8ed27b90c765fafc5d3
    Change-Id: I76175e33f506e35112ab9e86724caa3aea8f546d

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 16.0.0.0rc1 release candidate.