[RFE] a "--wait" option for creating/deleting a share group

Bug #1898318 reported by Goutham Pacha Ravi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-manilaclient
Fix Released
Low
Archana Kumari

Bug Description

Expected workflow:

1) Creating a share group

$ manila share-group-create --name share-group-1 --wait
<CLI waits on the share group to become available before providing group details>

2) Deleting a share group

$ manila share-group-delete share-group-1 --wait
<CLI waits on the share group to be deleted before returning to the prompt>

Changed in python-manilaclient:
assignee: nobody → Kafilat Adeleke (kafilat-adeleke)
Changed in python-manilaclient:
assignee: Kafilat Adeleke (kafilat-adeleke) → nobody
Changed in python-manilaclient:
assignee: nobody → Archana Kumari (archanaserver)
Changed in python-manilaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/789018
Committed: https://opendev.org/openstack/python-manilaclient/commit/f84f32e702edbbf2ca05434cdadbfa47af0cf0c0
Submitter: "Zuul (22348)"
Branch: master

commit f84f32e702edbbf2ca05434cdadbfa47af0cf0c0
Author: Archana Kumari <email address hidden>
Date: Sat May 1 00:45:26 2021 +0530

    Add --wait flag to the delete share group operation

    This patch set adds the --wait flag to the share group
    operation. This will make the CLI to wait for the
    operation to be completed before returning to the prompt.

    Updated test_share_delete to be test_share_delete_wait
    and included the waiter flag.

    Updated test_share_group_delete_force to test the
    correct calls.

    Also, updated test_share_group_update and test_share_group_show
    since they were randomnly failing depending on the test execution
    order. Mocks were being cleaned up and that was leading us to
    some errors. Created mocks for required resources within those
    tests to make it more stable.

    Partial-Bug: #1898318
    Change-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/799997
Committed: https://opendev.org/openstack/python-manilaclient/commit/376429ec1d848dcb1e49c63370ab07be89dec2b4
Submitter: "Zuul (22348)"
Branch: master

commit 376429ec1d848dcb1e49c63370ab07be89dec2b4
Author: archanaserver <email address hidden>
Date: Thu Jul 8 09:06:27 2021 +0000

    Add --wait flag to the create share group operation

    This patch set adds the --wait flag to the share group
    operation. This will make the CLI to wait for the
    operation to be completed before returning to the prompt.

    Updated test_share_group_create to be test_share_group_create_wait
    and included the waiter flag

    Partial-Bug: #1898318
    Change-Id: Id3e163de48bdd918ae55438d812187ba4d5461c9

Changed in python-manilaclient:
status: In Progress → Fix Committed
Changed in python-manilaclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.