manilaclient's OSC plugin uses openstackclient code but doesn't specify it in requirements.txt

[Goutham Pacha Ravi]

python-manilaclient includes an OSC plugin since its Ussuri release [1]

It's currently importing code from python-openstackclient, but python-openstackclient hasn't been added to its requirements.txt [2]:

https://opendev.org/openstack/python-manilaclient/src/commit/3371c543036a0f9f7b485489c490de4bd8cb52d1/manilaclient/osc/v2/share.py#L17

Feels like an anti pattern to use code from openstackclient, when there is an osc-lib for reusable, common code. Neutronclient has a copy of this common code in their repo to avoid depending on python-openstackclient [3]

[1] https://opendev.org/openstack/python-manilaclient/src/tag/2.0.0/manilaclient/osc
[2] https://opendev.org/openstack/python-manilaclient/src/tag/2.0.0/requirements.txt
[3] https://opendev.org/openstack/python-neutronclient/src/commit/15d99a7d68435132fd2fbd4ba604c3796802a83e/neutronclient/osc/utils.py#L32

[Goutham Pacha Ravi (gouthamr)]

I missed the openstackclient documentation regarding this: https://docs.openstack.org/python-openstackclient/latest/contributor/plugins.html#requirements

Looks like this anti pattern is specifically called out there. As such, this isn't a bug if this is what other projects are doing.