Failed to allow user group access to the share

Bug #1733494 reported by zhongjun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
kedy
python-manilaclient
Fix Released
Low
kedy

Bug Description

Failed to allow user group access to the share

Failed to allow user group access to the share when user group name include the blank.

for example:
root@ubuntu:~# manila access-allow 4dbbfe5d-a062-420c-a404-864c3290351d user "test group name"
root@ubuntu:~# ERROR: Invalid user or group name. Must be 4-255 characters and consist of alphanumeric characters and special characters $]{.-_'`;}[\

In Active Directory, the user group access name format can include the blank

But the user access name is not support the blank.

kedy (kedy)
Changed in manila:
assignee: nobody → 赵凯 (kedy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/522440

Changed in manila:
status: New → In Progress
zhongjun (jun-zhongjun)
Changed in python-manilaclient:
status: New → In Progress
Changed in python-manilaclient:
assignee: nobody → kedy (kedy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (master)

Change abandoned by Paul Belanger (<email address hidden>) on branch: master
Review: https://review.openstack.org/522440
Reason: We are dealing with an issue in zuulv3 today, as such we need to abandon / restore this patch to correct the issue. Apologies for the inconvenience.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/522440
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=fb613b93cd32edf1f72c7644b5672d2760016221
Submitter: Zuul
Branch: master

commit fb613b93cd32edf1f72c7644b5672d2760016221
Author: kedy <email address hidden>
Date: Thu Nov 23 12:49:08 2017 +0800

    Fix allow the use of blank in user group name to access the share

    Allows the use of blank in user group name, manila client also need to fix

    Change-Id: I636e485992185ed8a766eddb6cba89daff0bd00e
    Partial-Bug: #1733494

Tom Barron (tpb)
Changed in python-manilaclient:
importance: Undecided → Low
Changed in manila:
importance: Undecided → Low
status: In Progress → Fix Committed
Tom Barron (tpb)
Changed in manila:
milestone: none → rocky-3
Tom Barron (tpb)
Changed in python-manilaclient:
milestone: none → rocky-3
Revision history for this message
Tom Barron (tpb) wrote :

https://review.openstack.org/#/c/522444 addresses the client side

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/522444
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=3eeb76250ec936d5916cf0a3e22e3b1483e87d77
Submitter: Zuul
Branch: master

commit 3eeb76250ec936d5916cf0a3e22e3b1483e87d77
Author: kedy <email address hidden>
Date: Thu Nov 23 13:50:23 2017 +0800

    Fix allow the use of blank in user group name to access the share

    Allows the use of blank in user group name, manila api also need to fix

    Change-Id: I9ba2387198ce9e6a03be05d90e3b9455add76dcf
    Partial-Bug: #1733494

Changed in python-manilaclient:
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
Changed in manila:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.