Attr "description" can not be set for share type

Bug #1724183 reported by zhongjun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Tom Barron
python-manilaclient
Fix Released
Undecided
zhongjun

Bug Description

Attr "description" can be set in many resources. such as: share, share snapshot, group, share network ...
But attr "description" can not be set for share type. The users are hard to known what mean of the share type if we only show share type name for user.
$manila help type-create
usage: manila type-create [--snapshot_support <snapshot_support>]
                          [--create_share_from_snapshot_support <create_share_from_snapshot_support>]
                          [--revert_to_snapshot_support <revert_to_snapshot_support>]
                          [--mount_snapshot_support <mount_snapshot_support>]
                          [--extra-specs [<key=value> [<key=value> ...]]]
                          [--is_public <is_public>]
                          <name> <spec_driver_handles_share_servers>

Create a new share type (Admin only).

Positional arguments:
  <name> Name of the new share type.
  <spec_driver_handles_share_servers>
                        Required extra specification. Valid values are
                        'true'/'1' and 'false'/'0'.

Optional arguments:
  --snapshot_support <snapshot_support>, --snapshot-support <snapshot_support>
                        Boolean extra spec used for filtering of back ends by
                        their capability to create share snapshots.
  --create_share_from_snapshot_support <create_share_from_snapshot_support>, --create-share-from-snapshot-support <create_share_from_snapshot_support>
                        Boolean extra spec used for filtering of back ends by
                        their capability to create shares from snapshots.
  --revert_to_snapshot_support <revert_to_snapshot_support>, --revert-to-snapshot-support <revert_to_snapshot_support>
                        Boolean extra spec used for filtering of back ends by
                        their capability to revert shares to snapshots.
                        (Default is False).
  --mount_snapshot_support <mount_snapshot_support>, --mount-snapshot-support <mount_snapshot_support>
                        Boolean extra spec used for filtering of back ends by
                        their capability to mount share snapshots. (Default is
                        False).
  --extra-specs [<key=value> [<key=value> ...]], --extra_specs [<key=value> [<key=value> ...]]
                        Extra specs key and value of share type that will be
                        used for share type creation. OPTIONAL: Default=None.
                        example --extra-specs thin_provisioning='<is> True',
                        replication_type=readable.
  --is_public <is_public>, --is-public <is_public>
                        Make type accessible to the public (default true).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/512572

Changed in manila:
assignee: nobody → zhongjun (jun-zhongjun)
status: New → In Progress
Changed in manila:
importance: Undecided → Low
zhongjun (jun-zhongjun)
Changed in python-manilaclient:
status: New → In Progress
assignee: nobody → zhongjun (jun-zhongjun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/522189

Changed in manila:
assignee: zhongjun (jun-zhongjun) → Tom Barron (tpb)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/512572
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=125651d566d837ef4b41f58970dd2dede3b9ce7e
Submitter: Zuul
Branch: master

commit 125651d566d837ef4b41f58970dd2dede3b9ce7e
Author: zhongjun <email address hidden>
Date: Tue Oct 17 17:50:18 2017 +0800

    Add 'description' in share type APIs

    This fix add attr 'description' in list/create share
    type APIs.

    Change-Id: I39705acbfca812b66d74fbd2fee228a7a85bc2d8
    Closes-Bug: #1724183

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/522189
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=470e76d6b3ffe205f4193ba616bf3e9941e0a527
Submitter: Zuul
Branch: master

commit 470e76d6b3ffe205f4193ba616bf3e9941e0a527
Author: zhongjun <email address hidden>
Date: Wed Nov 22 17:27:13 2017 +0800

    Add 'description' in share type API Doc

    Add attr 'description' in list/create share
    type API Doc.

    Depends-On: I39705acbfca812b66d74fbd2fee228a7a85bc2d8
    Change-Id: I49705acbfca812b66d74fbd2fee228a7a85bc2d7
    Partial-Bug: #1724183

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 6.0.0.0b2

This issue was fixed in the openstack/manila 6.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/519961
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=8e8a3e7b71134e1b685d3d3da57ad78e2767e79b
Submitter: Zuul
Branch: master

commit 8e8a3e7b71134e1b685d3d3da57ad78e2767e79b
Author: zhongjun <email address hidden>
Date: Wed Nov 15 11:42:23 2017 +0800

    Added 'description' in share type

    This fix adds attr 'description' in list/create share
    type.

    Change-Id: I39705acbfca812b66d73fbd2fee228a7a85bc2d7
    Closes-Bug: #1724183

Changed in python-manilaclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 1.21.0

This issue was fixed in the openstack/python-manilaclient 1.21.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.