python-manilaclient

Manila client not working without public endpoint

Bug #1620491 reported by Christoph Fiehe on 2016-09-06

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	python-manilaclient	Fix Released	Low	Thomas Bechtold

Bug Description

When there is no public endpoint available, the shell manila client fails during version discovery.

The method "_discover_client" in "shell.py" uses a temporary client that gets created via the dictionary "client_args" that uses the publicURL for connecting to the manila service endpoint. It should either use the "endpoint_type" provided by "os_endpoint_type" or the adminURL.

Tags:

NidhiMittalHada (nidhimittal19) on 2017-04-06

Changed in python-manilaclient:
assignee:	nobody → NidhiMittalHada (nidhimittal19)

Ben Swartzlander (bswartz) on 2017-08-02

Changed in python-manilaclient:
assignee:	NidhiMittalHada (nidhimittal19) → nobody

Ben Swartzlander (bswartz) on 2017-08-02

Changed in python-manilaclient:
importance:	Undecided → Low
status:	New → Triaged

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-12: Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/503006

Changed in python-manilaclient:
assignee:	nobody → Dmitry Kudyukin (gmorfy)
status:	Triaged → In Progress

Valeriy Ponomaryov (vponomaryov) on 2017-09-19

tags:

added: pike-backport-potential

OpenStack Infra (hudson-openstack) on 2017-10-09

Changed in python-manilaclient:
assignee:	Dmitry Kudyukin (gmorfy) → Thomas Bechtold (toabctl)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-10: Fix proposed to python-manilaclient (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/510736

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-10: Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/503006
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=b9f897ec701b6fb6e5f383bf952814cc4d02f1e3
Submitter: Jenkins
Branch: master

commit b9f897ec701b6fb6e5f383bf952814cc4d02f1e3
Author: Kudyukin Dmitry <email address hidden>
Date: Tue Sep 12 16:55:50 2017 +0300

Fix for use endpoint_type in _discover_client method

    In _discover_client method endpoint_type gets DEFAULT_MANILA_ENDPOINT_TYPE
    rather getting endpoint type from shell. In case
    DEFAULT_MANILA_ENDPOINT_TYPE unavaliable client fails.

Co-Authored-By: Thomas Bechtold <email address hidden>
Closes-Bug: #1620491

Change-Id: I132fa448994b2f42e7fd8873425f81c88dbde8ee

Changed in python-manilaclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-10: Fix merged to python-manilaclient (stable/pike)

Reviewed: https://review.openstack.org/510736
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=7b88b1dce9b4980741fc5fc4d415f3190558e1bd
Submitter: Jenkins
Branch: stable/pike

commit 7b88b1dce9b4980741fc5fc4d415f3190558e1bd
Author: Kudyukin Dmitry <email address hidden>
Date: Tue Sep 12 16:55:50 2017 +0300

Fix for use endpoint_type in _discover_client method

    In _discover_client method endpoint_type gets DEFAULT_MANILA_ENDPOINT_TYPE
    rather getting endpoint type from shell. In case
    DEFAULT_MANILA_ENDPOINT_TYPE unavaliable client fails.

    Co-Authored-By: Thomas Bechtold <email address hidden>
    Closes-Bug: #1620491
    Change-Id: I132fa448994b2f42e7fd8873425f81c88dbde8ee
    (cherry picked from commit b9f897ec701b6fb6e5f383bf952814cc4d02f1e3)