Manilaclient init not compatible with old versions

[Valeriy Ponomaryov]

Commit [1] changed behaviour of main client init and it is not compatible with old versions anymore.

It causes error in all other projects that use Manilaclient where this change is applied.

One of this projects - OpenStack Rally, it uses always latest manilaclient, see errors in [2]. Where we have common error:

File "/opt/stack/new/python-manilaclient/manilaclient/client.py", line 44, in Client
     client_class = get_client_class(api_version.get_major_version())
 AttributeError: 'str' object has no attribute 'get_major_version'

[1] https://review.openstack.org/#/c/229142/

[2] http://logs.openstack.org/28/247828/1/check/gate-rally-dsvm-manila-multibackend/234383a/logs/devstack-gate-post_test_hook.txt.gz#_2015-11-20_00_29_14_915

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/248008

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/248008
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=d4ff416e2d23180cdea1ff300911e15fb5e90b15
Submitter: Jenkins
Branch: master

commit d4ff416e2d23180cdea1ff300911e15fb5e90b15
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Nov 20 12:19:50 2015 +0200

    Fix client backwards compatibility

    Change [1] introduced support of microversions to manilaclient and
    changed behaviour of client init that is not compatible with old
    approach. Also, not all old modules have deprecated modules in place.

    So, first problem description:
    - Old client expected string with api version, new one expects
    APIVersion class instance. So, add support for both and cover them with
    unit tests.

    Second problem description:
    - Manila UI project imports "manilaclient.v1.contrib.list_extensions"
    directly, but this file was moved to another place without keeping in
    place deprecated variant. So, add such to fix backward compatibility
    and allow to use newest manilaclient with manila-ui project.

    [1] I3733fe85424e39566addc070d42609e508259f19

    Change-Id: I838631fb38b8ddf1f4f1e06269af122bf51a5155
    Closes-Bug: #1518245

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-manilaclient 1.6.0 release.