insecure parameter to be removed for token based authentication

Bug #1718211 reported by Akshay Arora on 2017-09-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-kingbirdclient
Status tracked in Queens
Queens
High
Goutham Pratapa

Bug Description

https://github.com/openstack/python-kingbirdclient/blob/master/kingbirdclient/api/v1/client.py#L123

here we are using insecure parameter for token-based authentication but ideally, the insecure parameter should not be used for token-based authentication

so it is suggested to remove that parameter.

Current-scenario:

kingbird sync list --os-auth-token gAAAAABZwQwkeHNopwdDfE63FnZR37MLeyEMRc1d0WLDSOtEU86Y6rWS8kPV5gwiv52JsxictlIOnvXdwE_biwJP5u0csBkrZzvxyjQQ3BnCcNwEVWa0hd4tOTPxzNoyudAA29Kr-kZPbNpwrDAyjVLEdXG5s0ArqrWd7fa5XujcV1CVYIabKbE
ERROR (app) __init__() got an unexpected keyword argument 'insecure'

ideal scenario:

kingbird sync list --os-auth-token gAAAAABZwQwkeHNopwdDfE63FnZR37MLeyEMRc1d0WLDSOtEU86Y6rWS8kPV5gwiv52JsxictlIOnvXdwE_biwJP5u0csBkrZzvxyjQQ3BnCcNwEVWa0hd4tOTPxzNoyudAA29Kr-kZPbNpwrDAyjVLEdXG5s0ArqrWd7fa5XujcV1CVYIabKbE

 kingbird sync list
+--------------------------------------+---------+---------------------+---------------------+
| ID | STATUS | CREATED_AT | UPDATED_AT |
+--------------------------------------+---------+---------------------+---------------------+
| 7817a785-286f-4335-b823-0339f4a0ae9c | SUCCESS | 2017-09-18 12:44:35 | 2017-09-18 12:44:38 |
| b4c2ceb6-0d39-47c3-bf2f-d9bebb722e83 | SUCCESS | 2017-09-18 12:43:45 | 2017-09-18 12:43:50 |
+--------------------------------------+---------+---------------------+---------------------+

information type: Private Security → Public
Changed in python-kingbirdclient:
assignee: nobody → Goutham Pratapa (pratapagoutham)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-kingbirdclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/505598

Changed in python-kingbirdclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-kingbirdclient (master)

Reviewed: https://review.openstack.org/505598
Committed: https://git.openstack.org/cgit/openstack/python-kingbirdclient/commit/?id=2126e83d431566804f3942831554712c1a4406ec
Submitter: Jenkins
Branch: master

commit 2126e83d431566804f3942831554712c1a4406ec
Author: GouthamPratapa <email address hidden>
Date: Wed Sep 20 16:41:49 2017 +0530

    Remove "insecure" in token-based authentication.

    Currently, in kingbirdclient we are using insecure parameter for
    token-based authentication but insecure parameter shouldnot be
    used in token-based authentication.
    Closes-Bug: #1718211

    Change-Id: I322b26a3c8b2205d65c5788914a604f8dc667b96

Changed in python-kingbirdclient:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers