discrepancy in response of "check_*" methods

[Neha Alhat]

Description:
============

The 'check_tag' api from keystoneclient.v3.projects.py module returns True/False[1] but there are other places like[2][3] where similar "check_*" methods returns NotFound exception if the record doesn't exist. In case of "check_tag" method, even if the record doesn't exists, it returns "False".

To have consistency in response along all apis, need to add a deprecation warning first, and then change the response in next release such as add a @removals.remove and create a new function for the correct response.

[1]: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v3/projects.py#L334-L340
[2]: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v3/roles.py#L288
[3]: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v3/users.py#L247

[Colleen Murphy (krinkle)]

Thanks for reporting this. It's unfortunate that it's a bit inconsistent, but it is at least documented, and IMO not a tremendous burden. In general we're trying to move toward doing all new work in openstacksdk and not python-keystoneclient, and I think the hassle of going through the deprecation process for these modules outweighs the benefits of changing the interfaces. Therefore I'm closing this as "Won't Fix".