filter_kwargs adds extra _id to key
Bug #1742800 reported by
Adrian Turjak
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| python-keystoneclient |
In Progress
|
Medium
|
Adrian Turjak | ||
Bug Description
In the filter_kwargs decorator if the id_value does not match the ref, we add '_id' to the key. This means if someone supplies a param as some_function(
The issue is that this doesn't throw an error, and a user may assume the API call is actually using/filtering by the user_id value supplied, when in truth it isn't.
Simple fix, check if the key already ends with "_id", and then only if not append the postfix.
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix proposed to python-keystoneclient (master) | #1 |
| Changed in python-keystoneclient: | |
| assignee: | nobody → Adrian Turjak (adriant-y) |
| status: | New → In Progress |
| Changed in python-keystoneclient: | |
| importance: | Undecided → Medium |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Change abandoned on python-keystoneclient (master) | #2 |
To post a comment you must log in.
Fix proposed to branch: master
Review: https:/