python-keystoneclient

Regex in ec2/utils.py is wrong

Bug #1658639 reported by Maroun Maroun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Low
Maroun Maroun

Bug Description

The following

strip_port = re.match('Boto/2.[0-9].[0-2]', user_agent)

should be

strip_port = re.match('Boto/2\.[0-9]\.[0-2]', user_agent)

as the "." may match anything, like: "Boto/2x0t2".

Boris Bobrov (bbobrov)
no longer affects: keystone
Revision history for this message
Boris Bobrov (bbobrov) wrote :

The code is there from 2013-07-26, so i guess nobody hit that bug since then

Changed in python-keystoneclient:
status: New → Confirmed
importance: Undecided → Low
Maroun Maroun (maroun.bassam)
Changed in python-keystoneclient:
assignee: nobody → Maroun Maroun (maroun.bassam)
Maroun Maroun (maroun.bassam)
Changed in python-keystoneclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/424700

OpenStack Infra (hudson-openstack)
Changed in python-keystoneclient:
assignee: Maroun Maroun (maroun.bassam) → Steve Martinelli (stevemar)
Steve Martinelli (stevemar)
Changed in python-keystoneclient:
assignee: Steve Martinelli (stevemar) → Maroun (maroun-maroun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/424848

Changed in python-keystoneclient:
assignee: Maroun (maroun-maroun) → Maroun Maroun (maroun.bassam)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-keystoneclient (master)

Change abandoned by Samuel de Medeiros Queiroz (<email address hidden>) on branch: master
Review: https://review.openstack.org/424471
Reason: Abandoning as it is duplicated patch from same author, please feel free to restore if necessary.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Samuel de Medeiros Queiroz (<email address hidden>) on branch: master
Review: https://review.openstack.org/424848
Reason: Same author, same patch, abandoning in favor of https://review.openstack.org/#/c/424700/

Changed in python-keystoneclient:
assignee: Maroun Maroun (maroun.bassam) → Samuel de Medeiros Queiroz (samueldmq)
Samuel de Medeiros Queiroz (samueldmq)
Changed in python-keystoneclient:
assignee: Samuel de Medeiros Queiroz (samueldmq) → Maroun Maroun (maroun.bassam)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/424700
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=2e6459f2f1c0c574c76a3ddf55a2fbb85cf7b7ef
Submitter: Jenkins
Branch: master

commit 2e6459f2f1c0c574c76a3ddf55a2fbb85cf7b7ef
Author: MarounMaroun <email address hidden>
Date: Mon Jan 23 15:11:09 2017 +0200

    Fix boto version strip regex

    the current regex pattern will match incorrect
    strings like: Boto/2x0t2

    Change-Id: I260f4e0d98f082172a3a67a1fbaa05da5369ea49
    Closes-Bug: #1658639

Changed in python-keystoneclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-keystoneclient 3.11.0

This issue was fixed in the openstack/python-keystoneclient 3.11.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.