test_implied_roles fails intermittently

Bug #1609398 reported by Samuel de Medeiros Queiroz on 2016-08-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Medium
Samuel de Medeiros Queiroz

Bug Description

test_implied_roles [1] is failing intermitently. See [2] as an example.

That test is asserting that the initial role count added to the number of roles created in the test matches what is currently returned by the server.

However, as there are many (at least 25) API calls happening in the meantime, it is not hard to have another test (running in parallel) touching roles, thus making the test fail with not matching counts.

It should be okay to simply remove such check from that test, as the test (implied roles test) is not supposed to assert the number of roles.

[1] https://github.com/openstack/python-keystoneclient/blob/41129c850394e97947ec374dad8e852b5e1b33b5/keystoneclient/tests/functional/v3/test_implied_roles.py#L50-L62

[2] https://review.openstack.org/#/c/334546/11

Changed in keystone:
importance: Undecided → Medium
assignee: nobody → Samuel de Medeiros Queiroz (samueldmq)
Changed in keystone:
status: New → Invalid
Changed in python-keystoneclient:
importance: Undecided → Critical
importance: Critical → Medium
assignee: nobody → Samuel de Medeiros Queiroz (samueldmq)
Changed in keystone:
assignee: Samuel de Medeiros Queiroz (samueldmq) → nobody
no longer affects: keystone
Changed in python-keystoneclient:
status: New → In Progress

Reviewed: https://review.openstack.org/350562
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=3870b8a763eb473abde37bd44ed3269919408094
Submitter: Jenkins
Branch: master

commit 3870b8a763eb473abde37bd44ed3269919408094
Author: Samuel de Medeiros Queiroz <email address hidden>
Date: Wed Aug 3 09:46:58 2016 -0300

    Correct test_implied_roles

    That test is not supposed to test the count of roles. It is about role
    inference rules. This change removes the pure role checks, as it is not
    the main intent of the test.

    This also fixes a related bug where this test is failing
    intermittently. See the bug description for more details.

    Change-Id: I8ea1b6d8f344296486427a1f9ebc31c58314501e
    Closes-Bug: 1609398

Changed in python-keystoneclient:
status: In Progress → Fix Released

This issue was fixed in the openstack/python-keystoneclient 3.5.0 release.

This issue was fixed in the openstack/python-keystoneclient 3.5.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers