socket.TCP_KEEPCNT and socket.KEEPINTVL do not exist in windows

[Claudiu Belu]

The python module 'socket' does not contain the attributes TCP_KEEPCNT or KEEPINTVL on Windows, which can cause issues for modules using the keystone client, such as nova (see log).

socket module contents on Windows: http://paste.openstack.org/show/412544/

Log: http://paste.openstack.org/show/tUb4rXXtmV9Nafw10GzL/

[David Stanek (dstanek)]

This is definitely a problem. I'm not sure about the priority since we don't advertise in our trove categories that we support Windows and I can't remember seeing a Windows discussion in the past.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/211686

[Claudiu Belu (cbelu)]

I would argue that this deserves a higher importance. It seems instances fail to spawn due to this issue in nova-compute on Hyper-V.

[Ian Cordasco (icordasc)]

Claudiu, which version of windows did you test this against?

[Claudiu Belu (cbelu)]

Windows Server 2012 R2.

[John Garbutt (johngarbutt)]

Seeing the same with OS X 10.10 and running python-novaclient unit tests.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/211686
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=33b24a6984c8de2f26af7900202bb85b6b5db125
Submitter: Jenkins
Branch: master

commit 33b24a6984c8de2f26af7900202bb85b6b5db125
Author: Claudiu Belu <email address hidden>
Date: Tue Aug 11 10:34:40 2015 -0700

    Fixes missing socket attribute error during init_poolmanager

    On Windows, the 'socket' python module does not contain the
    attributes TCP_KEEPCNT or TCP_KEEPINTVL, causing services
    consuming the library to malfunction.

    Adds conditionals for adding the mentioned socket attributes
    to the socket options.

    socket.SIO_KEEPALIVE_VALS cannot be added as a socket option
    for Windows, as there is another way entirely to enable that
    option.

    Change-Id: I2e9746ae65400bbd23c3b48dfc3167de9eb66494
    Partial-Bug: #1483696

[Dolph Mathews (dolph)]

The above fix appears to have mistakenly been marked as Partial-Bug, although it seems to resolve this issue. If that's not true, please re-open this bug.