Remove keystoneclient.middleware

Bug #1449066 reported by Victor Stinner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Medium
Steve Martinelli

Bug Description

The code has been moved to the new keystonemiddleware project and keystone.middleware was deprecated since Juno. It's time to drop it in Liberty.

The deprecation is documented:
http://docs.openstack.org/developer/python-keystoneclient/api/keystoneclient.middleware.html

Changed in python-keystoneclient:
assignee: nobody → Victor Stinner (victor-stinner)
status: New → In Progress
Changed in python-keystoneclient:
importance: Undecided → Medium
milestone: none → 1.4.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/177694
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=37742ec52082f14a8467a464a431987ac1b5df7a
Submitter: Jenkins
Branch: master

commit 37742ec52082f14a8467a464a431987ac1b5df7a
Author: Victor Stinner <email address hidden>
Date: Mon Apr 27 10:37:01 2015 +0200

    Remove keystoneclient.middleware

    The code has been moved to the new keystonemiddleware project and
    keystone.middleware was deprecated since Juno. It's time to drop it in
    Liberty.

    Remove the directory keystoneclient/middleware/.

    Remove test_auth_token_middleware.py, test_memcache_crypt.py and
    test_s3_token_middleware.py in keystoneclient/tests/unit/.

    Remove the create_middleware_cert shell function from
    examples/pki/gen_pki.sh. And remove the call from
    examples/pki/run_all.sh.

    Remove netaddr, pycrypto and WebOb test dependencies, only needed to
    test the removed middleware.

    DocImpact: The keystoneclient.middleware module has been removed

    Closes-Bug: #1449066
    Change-Id: I88ddfdb674db1ec9c0fd4f9a62ae8347785ea10c

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Changed in python-keystoneclient:
milestone: 1.4.0 → 2.0.0
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (feature/keystoneauth_integration)

Fix proposed to branch: feature/keystoneauth_integration
Review: https://review.openstack.org/195338

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-keystoneclient (master)

Change abandoned by Victor Stinner (<email address hidden>) on branch: master
Review: https://review.openstack.org/192752
Reason: > Propose this change to the keystoneauth_integration branch. That's going to be 2.0.

Great! Morgan Fainberg did that for me :-) It's the change Idd3b7d730b70ecf4fa6be911078d02e8bdfc9f37.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (feature/keystoneauth_integration)

Reviewed: https://review.openstack.org/195338
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=d5c5423d6de3710e3480e47062333b33e8de0713
Submitter: Jenkins
Branch: feature/keystoneauth_integration

commit d5c5423d6de3710e3480e47062333b33e8de0713
Author: Victor Stinner <email address hidden>
Date: Mon Apr 27 10:37:01 2015 +0200

    Remove keystoneclient.middleware

    The code has been moved to the new keystonemiddleware project and
    keystone.middleware was deprecated since Juno. It's time to drop it in
    Liberty.

    Remove the directory keystoneclient/middleware/.

    Remove test_auth_token_middleware.py, test_memcache_crypt.py and
    test_s3_token_middleware.py in keystoneclient/tests/unit/.

    Remove the create_middleware_cert shell function from
    examples/pki/gen_pki.sh. And remove the call from
    examples/pki/run_all.sh.

    Remove netaddr, pycrypto and WebOb test dependencies, only needed to
    test the removed middleware.

    DocImpact: The keystoneclient.middleware module has been removed

    Change-Id: Idd3b7d730b70ecf4fa6be911078d02e8bdfc9f37
    Closes-Bug: #1449066

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/250669

Changed in python-keystoneclient:
assignee: Victor Stinner (victor-stinner) → Boris Bobrov (bbobrov)
Changed in python-keystoneclient:
assignee: Boris Bobrov (bbobrov) → Steve Martinelli (stevemar)
Changed in python-keystoneclient:
milestone: 2.0.0 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/250669
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=646350c1d6dcd02c4dd939a220e231eedff5b055
Submitter: Jenkins
Branch: master

commit 646350c1d6dcd02c4dd939a220e231eedff5b055
Author: Victor Stinner <email address hidden>
Date: Mon Apr 27 10:37:01 2015 +0200

    Remove keystoneclient.middleware

    The code has been moved to the new keystonemiddleware project and
    keystone.middleware was deprecated since Juno. It's time to drop it in
    Mitaka.

    Remove the directory keystoneclient/middleware/.

    Remove test_auth_token_middleware.py, test_memcache_crypt.py and
    test_s3_token_middleware.py in keystoneclient/tests/unit/.

    Remove the create_middleware_cert shell function from
    examples/pki/gen_pki.sh. And remove the call from
    examples/pki/run_all.sh.

    Remove netaddr, pycrypto and WebOb test dependencies, only needed to
    test the removed middleware.

    Closes-Bug: #1449066
    Change-Id: Iedd6887dcde62177d37e1e1988ed72bcb59c05f6

Changed in python-keystoneclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-keystoneclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/257131

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/257131
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=afb46ab7a0d73b3a0bfa3d54f76674491e7b43d6
Submitter: Jenkins
Branch: master

commit afb46ab7a0d73b3a0bfa3d54f76674491e7b43d6
Author: Steve Martinelli <email address hidden>
Date: Mon Dec 14 00:43:04 2015 -0500

    remove oslo-incubator's memorycache

    with middleware removed from keystoneclient we no longer need
    to keep memorycache around.

    Change-Id: I98d8ddd1398699f8821e4c36fe911c9d211c46a9
    Related-Bug: #1449066

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-keystoneclient 2.1.0

This issue was fixed in the openstack/python-keystoneclient 2.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.