memcache tests are skipped on python 3

Bug #1447731 reported by Clint Byrum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keystonemiddleware
Fix Released
Medium
Unassigned
python-keystoneclient
Won't Fix
Undecided
Unassigned
python-keystonemiddleware (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

Currently the py34 test environment loads a set of test requirements that don't include python-memcached. This leads to tests being skipped, and an incompatibility for python-keystoneclient on python3.

Ran 1073 tests in 10.056s
PASSED (id=0, skips=3)

keystoneclient/tests/unit/test_auth_token_middleware.py: @testtools.skipUnless(memcached_available(), 'memcached not available')
keystoneclient/tests/unit/test_auth_token_middleware.py: @testtools.skipUnless(memcached_available(), 'memcached not available')
keystoneclient/tests/unit/test_auth_token_middleware.py: @testtools.skipUnless(memcached_available(), 'memcached not available')

Changed in python-keystoneclient:
assignee: nobody → Anand Shanmugam (anand1712)
Changed in python-keystoneclient:
assignee: Anand Shanmugam (anand1712) → nobody
Revision history for this message
Victor Stinner (vstinner) wrote :

> memcache tests are skipped on python 3

Tests are skipped for a good reason: python-memcached 1.54 (latest release) doesn't work on Python 3.

Hum, on a fresh system, memcache tests are also skipped on Python 2 because python-memcached is missing in test dependencies! I wrote a first patch to enable these tests on Python 2:
https://review.openstack.org/#/c/176778/

I also wrote a patch to finish the python-memcached port to Python 3:
https://github.com/linsomniac/python-memcached/pull/67

When python-memcached will really work on Python 3, I will write a second patch to enable memcache tests of keystoneclient on Python 3 too.

Revision history for this message
Victor Stinner (vstinner) wrote :

Brant Knudson wrote that the middleware in python-keystoneclient was deprecated in Juno. We may remove it during the Liberty cycle. The code was moved to a new keystonemiddle component.

The bug is still valid for keystonemiddle.

Revision history for this message
Morgan Fainberg (mdrnstm) wrote :

This will not be fixed in python-keystoneclient as python-keystoneclient will be dropping the middleware in the Liberty cycle.

Changed in python-keystoneclient:
status: New → Won't Fix
Changed in python-keystonemiddleware (Ubuntu):
status: New → Confirmed
status: Confirmed → Invalid
Revision history for this message
Morgan Fainberg (mdrnstm) wrote :

python-keystonemiddleware is not the correct LP project.

Changed in keystonemiddleware:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Morgan Fainberg (mdrnstm) wrote :

This is being marked as medium priority for the keystonemiddleware package, as the issue is that the python-memcache library is not fully python3 compatible (and downright poorly built). keystonemiddleware should move to dogpile.cache instead and allow for various generic caching backends that can work with python2 and 3 as deployers need.

Changed in keystonemiddleware:
importance: Low → Medium
Revision history for this message
Steve Martinelli (stevemar) wrote :
Changed in keystonemiddleware:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.