enabled parameter of update should default to None

Bug #1413071 reported by wanghong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Medium
wanghong

Bug Description

Currently, enabled parameter of v3.domains.update and v3.regions.update defaults to True. It is easy to make mistakes and difficult to use.
If someone doesn't notice this, the value of enabled would be set to True if he just specifies name parameter to update the name of domain or region. It is easy to make mistakes.
And if he notices this, he must specify both name and enabled parameters to update the name of domain or region. It is difficult to use.

wanghong (w-wanghong)
description: updated
Changed in python-keystoneclient:
assignee: nobody → wanghong (w-wanghong)
Changed in python-keystoneclient:
importance: Undecided → Medium
status: New → Confirmed
Changed in python-keystoneclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/144422
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=acfbff0258e9f8de2b49ddf7af927b67d1dbba1d
Submitter: Jenkins
Branch: master

commit acfbff0258e9f8de2b49ddf7af927b67d1dbba1d
Author: wanghong <email address hidden>
Date: Tue Dec 30 17:14:48 2014 +0800

    fix enabled parameter of update doesn't default to None

    Currently, enabled parameter of v3.domains.update and v3.regions.update
    defaults to True. It is easy to make mistakes and difficult to use.

    Closes-Bug: #1413071
    Change-Id: I8b392ff228691b2735b06747dcfb802d4c191a54

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Changed in python-keystoneclient:
milestone: none → 1.1.0
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.