Version discovery fails with default Keystone config

[Dean Troyer]

The URLs returned inKeystone's version response (GET /) are set in keystone.conf with admin_endpoint and public_endpoint. The default for both of those is 'http://localhost:xxxx/' where xxxx is the configured port. With the introduction of version discovery in keystoneclient this default configuration no longer properly works for anything except an all-in-one configuration where the client is also on the same server (ie, DevStack).

This does not seem to be a wide-spread problem but clouds configured in this manner are in the wild, and generally older releases that can not or will not be upgraded soon. This fix (see below) could be done in KSC's auth plugins to make it universally available. A proof-of-concept has been done in OpenStackClient (https://review.openstack.org/145681) and may (will?) remain there if it is not added to KSC.

A simple work-around for this problem is to use the scheme and host from the authentication URL used to get the version response in the returned endpoint when the endpoint host is 'localhost'.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/147284

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/145681
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=d3b87d7795356d3c4e4b6f578a1f426a74f9afbd
Submitter: Jenkins
Branch: master

commit d3b87d7795356d3c4e4b6f578a1f426a74f9afbd
Author: Dean Troyer <email address hidden>
Date: Wed Jan 7 22:01:21 2015 -0600

    Add version url config workaround

    This subclasses KSC's generic Password plugin to allow version discovery with
    default Keystone configurations that leave admin_endpoint and public_endpoint
    at the default values (http://localhost:xxxx). This patch copies the scheme
    and netloc from the original auth_url into the URL returned from version
    discovery if the returned netloc begins with 'localhost'.

    Due to the specific nature of this review, the Keystone team is not
    inclned to include it in keystoneclient so it is addressed here.

    Closes-bug: #1410364
    Change-Id: I877fe74d86aab3a63122a07b77d1302a007f5b30

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dean Troyer (<email address hidden>) on branch: master
Review: https://review.openstack.org/147284
Reason: Handled in OpenStackClient

[Steve Martinelli (stevemar)]

seems like fixing this in OSC was the right move