BaseGenericPlugin redundant get_options() calls causes arg conflict

[David J Hu]

     21 from keystoneclient.auth.identity import base

     27 def get_options():
     28 return base.get_options() + [ <== 3. call get_option from base, which is *not* necessary. This resulted in duplicate --os-auth-url, which is a conflict.
     29 cfg.StrOpt('domain-id', help='Domain ID to scope to'),
     30 cfg.StrOpt('domain-name', help='Domain name to scope to'),
     31 cfg.StrOpt('tenant-id', help='Tenant ID to scope to'),
     32 cfg.StrOpt('tenant-name', help='Tenant name to scope to'),

    176 @classmethod
    177 def get_options(cls):
    178 options = super(BaseGenericPlugin, cls).get_options() <== 1. Get the options from super, which calls base.get_options()
    179 options.extend(get_options()) <== 2. Call get_options() at line 27.
    180 return options

[David J Hu (david-j-hu)]

keystoneclient/auth/identity/generic/base.py

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/132652

[Dolph Mathews (dolph)]

It's not really clear what is being duplicated from this bug report; what is the effect you're seeing?

[Jamie Lennox (jamielennox)]

Bug is correct.

If you use the generic password plugin from a CLI (which is really the plugin i hope to be default) it will try to add the --os-auth-url option to the parser twice because it is listed in the get_options twice. This is not allowed in argparse and will fail so generic.Password is unusable from the CLI.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/132652
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=b7da6d0e8449355fa7652523ee5ad0b36b298399
Submitter: Jenkins
Branch: master

commit b7da6d0e8449355fa7652523ee5ad0b36b298399
Author: wanghong <email address hidden>
Date: Tue Nov 4 18:54:59 2014 +0800

    duplicate auth-url option returned by BaseGenericPlugin

    The free function get_options() should only return the options that
    the object itself needs.

    Change-Id: Id54f353d8b125807a8fc33b4bca8854605e3febb
    Closes-Bug: #1388954