Meaningless replacing of slashes with dashes in PKI tokens
Bug #1352314 reported by
Kirill Zaborsky
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-keystoneclient |
Fix Released
|
Medium
|
Deepti Ramakrishna |
Bug Description
It looks like Keystone uses some a bit strange conception of Base64 which does not include slashes - https:/
http://
So currently for some unknown reason Keystone replaces slashes with dashes when returning tokens and does the opposite when reading tokens.
I understand that fixing this will break backwards compatibility but it makes sense at least to document this strange behaviour so developers accessing Keystone not with Keystone original bindings (e.g. from othe languages) will not be caught by surprise.
Changed in python-keystoneclient: | |
assignee: | nobody → Deepti Ramakrishna (dramakri) |
Changed in python-keystoneclient: | |
milestone: | none → 1.4.0 |
Changed in python-keystoneclient: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I completely agree - the methods doing the string manipulation don't give any clue behind the behavior either.
It's actually being done to ensure URL-safety, despite the existing presence of and lack of compatibility with the base64 module's URL-safe builtin methods:
https:/ /docs.python. org/2/library/ base64. html#base64. urlsafe_ b64encode