v3/credentials create/update broken

Bug #1259461 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Medium
Steven Hardy

Bug Description

The v3 CredentialManager code passes an argument of "data" as the data blob to create/update, but this doesn't work because the underlying API expects "blob":

https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#create-credential-post-credentials

https://github.com/openstack/keystone/blob/master/keystone/credential/controllers.py#L39

Consequently create and update fail with 'Invalid blob in credential' if you specify a type of 'ec2'.

Steven Hardy (shardy)
Changed in python-keystoneclient:
assignee: nobody → Steven Hardy (shardy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/61046

Changed in python-keystoneclient:
status: New → In Progress
Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/61046
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=045e03d85284f4b0f5fffc656d90b922fb348b42
Submitter: Jenkins
Branch: master

commit 045e03d85284f4b0f5fffc656d90b922fb348b42
Author: Steven Hardy <email address hidden>
Date: Tue Dec 10 08:51:52 2013 +0000

    Fix error in v3 credentials create/update

    The v3 credentials passes data associated with the credential in
    a "data" key, but the underlying API expects "blob", which is also
    what is documented in the API spec.

    Currently any attempt to create a credential with a type of 'ec2'
    will fail with 'Invalid blob in credential' So s/data/blob to fix.

    Change-Id: I0858e8c39653477eb554ee9d15fb4f2dde2b195c
    Closes-Bug: #1259461

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.4.2
Dolph Mathews (dolph)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-keystoneclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/352567

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/352567
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=15869f4a589030b26b71599dc4bf42a1c44bfa05
Submitter: Jenkins
Branch: master

commit 15869f4a589030b26b71599dc4bf42a1c44bfa05
Author: Samuel de Medeiros Queiroz <email address hidden>
Date: Mon Aug 8 15:55:53 2016 -0300

    Remove deprecated 'data' credential argument

    The 'data' argument was deprecated in the 1.7.0 release
    and should have been removed in the 2.0.0 release. It has
    been replaced by the 'blob' argument.

    Related-Bug: 1259461

    Change-Id: I762f46f605a65abe73547ad6e522c54b1cc3aac6

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.