concurrency error in auth_token error

Bug #1209300 reported by Chmouel Boudjnah
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
High
Clark Boylan

Bug Description

I got hit by it in :

https://review.openstack.org/#/c/40601/

Tests run ok most of the time :

http://paste.openstack.org/raw/43442/

but in some random order would fail when launched directly :

http://paste.openstack.org/show/43454/

as discussed on #openstack-infra with clarkb :

18:05 clarkb: chmouel: cms.subprocess is None
18:05 clarkb: chmouel: my guess is somewhere another test is either importing the proper bits or instantiating that object
18:06 clarkb: and this test needs to do the same

Changed in python-keystoneclient:
assignee: nobody → Clark Boylan (cboylan)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/40671
Committed: http://github.com/openstack/python-keystoneclient/commit/fb7aae4e966d8bc4db75698d956a3e66cb4824ec
Submitter: Jenkins
Branch: master

commit fb7aae4e966d8bc4db75698d956a3e66cb4824ec
Author: Clark Boylan <email address hidden>
Date: Wed Aug 7 09:24:58 2013 -0700

    Fix test_request_no_token_dummy cms dependency.

    * tests/test_auth_token_middleware.py: test_request_no_token_dummy has a
    dependency on the keystone.common.cms module importing subprocess prior
    to running. The cms._ensure_subprocess() function does this. Call this
    function in the base test class's setUp method to ensure subprocess is
    imported before symbols from that module are needed. Doing this in the
    base setUp will ensure that this works for any additional tests with the
    same dependency.

    This fix is needed because testr runs tests in non deterministic order
    which means that each test needs to be able to run on its own (eg in its
    own process without any other tests running first) and they need to run
    without interfering any other tests (each test must properly clean up
    after itself). Prior to this commit test_request_no_token_dummy would
    fail when executed on its own.

    Closes-Bug: #1209300
    Change-Id: I3cf669b94ed77ad0cd729ead0b4162a3f1b8819f

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → High
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.3.2
Dolph Mathews (dolph)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.