concurrency error in auth_token error
Bug #1209300 reported by
Chmouel Boudjnah
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-keystoneclient |
Fix Released
|
High
|
Clark Boylan |
Bug Description
I got hit by it in :
https:/
Tests run ok most of the time :
http://
but in some random order would fail when launched directly :
http://
as discussed on #openstack-infra with clarkb :
18:05 clarkb: chmouel: cms.subprocess is None
18:05 clarkb: chmouel: my guess is somewhere another test is either importing the proper bits or instantiating that object
18:06 clarkb: and this test needs to do the same
Changed in python-keystoneclient: | |
assignee: | nobody → Clark Boylan (cboylan) |
status: | New → In Progress |
Changed in python-keystoneclient: | |
importance: | Undecided → High |
Changed in python-keystoneclient: | |
milestone: | none → 0.3.2 |
Changed in python-keystoneclient: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/40671 github. com/openstack/ python- keystoneclient/ commit/ fb7aae4e966d8bc 4db75698d956a3e 66cb4824ec
Committed: http://
Submitter: Jenkins
Branch: master
commit fb7aae4e966d8bc 4db75698d956a3e 66cb4824ec
Author: Clark Boylan <email address hidden>
Date: Wed Aug 7 09:24:58 2013 -0700
Fix test_request_ no_token_ dummy cms dependency.
* tests/test_ auth_token_ middleware. py: test_request_ no_token_ dummy has a subprocess( ) function does this. Call this
dependency on the keystone.common.cms module importing subprocess prior
to running. The cms._ensure_
function in the base test class's setUp method to ensure subprocess is
imported before symbols from that module are needed. Doing this in the
base setUp will ensure that this works for any additional tests with the
same dependency.
This fix is needed because testr runs tests in non deterministic order no_token_ dummy would
which means that each test needs to be able to run on its own (eg in its
own process without any other tests running first) and they need to run
without interfering any other tests (each test must properly clean up
after itself). Prior to this commit test_request_
fail when executed on its own.
Closes-Bug: #1209300 d0cd729ead0b416 2a3f1b8819f
Change-Id: I3cf669b94ed77a