memcache_servers configuration option

Bug #1086125 reported by Kevin L. Mitchell
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Invalid
Undecided
Unassigned
Folsom
Invalid
Undecided
Unassigned
python-keystoneclient
Fix Released
Medium
Kevin L. Mitchell

Bug Description

The memcache_servers configuration option is already declared as a ListOpt, but when used in AuthProtocol.__init__(), a .split() is attempted, which of course fails.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/17413

Changed in python-keystoneclient:
assignee: nobody → Kevin L. Mitchell (klmitch)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/17413
Committed: http://github.com/openstack/python-keystoneclient/commit/6b72fb626af57a85d1b3411d0c7e8b3d8fdc33b2
Submitter: Jenkins
Branch: master

commit 6b72fb626af57a85d1b3411d0c7e8b3d8fdc33b2
Author: Kevin L. Mitchell <email address hidden>
Date: Mon Dec 3 14:24:38 2012 -0600

    Don't try to split a list of memcache servers

    The memcache_servers configuration option is declared as a ListOpt,
    but when used in AuthProtocol.__init__(), we treat it as a string
    to be split on ',', which is wrong. Remove the .split().

    No test is added because the memcache package may not be installed,
    and I cannot see an easy method to only test this clause if it is
    available.

    Fixes bug 1086125.

    Change-Id: Ifb0a18017d2407b3ccb2188b1a704c26997ba594

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Revision history for this message
Alan Pevec (apevec) wrote :

BTW this bug was a side-effect of https://github.com/openstack/keystone/commit/174964498ba098f206d27119ce58d9fa6f43d302

One issue with the merged fix is that it won't parse multiple servers when using filter parameters from paste.ini which is supported for backward compatibility. I'll propose a followup fix.

Alan Pevec (apevec)
Changed in keystone:
status: New → Invalid
Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → Medium
status: Fix Committed → Fix Released
milestone: none → 0.2.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.