Fallback to root endpoint (when negotiating an API version) does not work

Bug #1726870 reported by Dmitry Tantsur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-ironicclient
Fix Released
Medium
Dmitry Tantsur

Bug Description

Currently this code patch can be hit by doing:

 $ openstack --debug baremetal node list --os-baremetal-api-version 1

The error response does not contain the version header (which is probably a bug on its own), so ironicclient tries to fetch /v1, but fails with:

 EndpointNotFound: Could not find requested endpoint in Service Catalog.

This is because SessionClient._make_simple_request does not provide enough information to Session about the required catalog endpoint.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ironicclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/514673

Changed in python-ironicclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ironicclient (master)

Reviewed: https://review.openstack.org/514673
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=534810fd038e99ecf295d67860e87b79f195547e
Submitter: Zuul
Branch: master

commit 534810fd038e99ecf295d67860e87b79f195547e
Author: Dmitry Tantsur <email address hidden>
Date: Tue Oct 24 15:35:25 2017 +0200

    Pass missing arguments to session in SessionClient._make_session_request

    If a server does not return API version headers, this will make the fallback
    to /v1 work correctly.

    Change-Id: I42b66daea1f4397273a3f4eb1638abafb3bb28ce
    Closes-Bug: #1726870

Changed in python-ironicclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-ironicclient 2.0.0

This issue was fixed in the openstack/python-ironicclient 2.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.