[RFE] Revisit 'openstack baremetal node maintenance set|unset'

[Ruby Loo]

I'm not sure that our two OSC commands for node maintenance are 'right'. We have:
- openstack baremetal node maintenance set
- openstack baremetal node maintenance unset

Sam Betts prefers enable/disable, or on/off, because he thinks of it as 'maintenance mode'.

There is an existing openstack command that has maintenance:
  $ openstack -h host set
  usage: openstack host set [-h] [--enable | --disable]
                            [--enable-maintenance | --disable-maintenance]
                            <host>

  Set host properties

  positional arguments:
    <host> The host to modify (name or ID)

  optional arguments:
    -h, --help show this help message and exit
    --enable Enable the host
    --disable Disable the host
    --enable-maintenance Enable maintenance mode for the host
    --disable-maintenance
                          Disable maintenance mode for the host

Although I'm not totally convinced the host command is similar to ours. For one thing, there is no 'openstack host unset' command.

I think if we want an 'openstack baremetal node maintenance <action>', we ought to decide what set of verbs/actions work well with maintenance:
a. on/off
b. enable/disable (that host command would be a vote for this)
c. set/unset

On the other hand, I wonder whether we should just modify those via the existing 'openstack baremetal node set|unset' commands, eg:
- openstack baremetal node set --maintenance [<reason>]
- openstack baremetal node unset --maintenance

[Ruby Loo (rloo)]

I also noticed this osc command, has --disable and --disable-reason. (There's no corresponding 'unset' command). Which is a vote for 'openstack baremetal node set --maintenance I think.:

    usage: openstack compute service set [-h] [--enable | --disable]
                                         [--disable-reason <reason>]
                                         <host> <service>

    Set service command

    positional arguments:
      <host> Name of host
      <service> Name of service

    optional arguments:
      -h, --help show this help message and exit
      --enable Enable service
      --disable Disable service
      --disable-reason <reason>
                            Reason for disabling the service (in quotas). Should
                            be used with --disable option.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/372973

[OpenStack Infra (hudson-openstack)]

Change abandoned by Himanshu Kumar (<email address hidden>) on branch: master
Review: https://review.openstack.org/372973
Reason: Submitted: https://review.openstack.org/#/c/373096/

[Ruby Loo (rloo)]

Himanshu, I am unassigning you from this bug since the patch you submitted doesn't address this bug, and I've taken over that patch to address another bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/480188

[Iury Gregory Melo Ferreira (iurygregory)]

Invalid, change was abandoned, re-open if necessary