[RFE] openstackclient cmd for 'ironic driver-raid-logical-disk-properties'

[Ruby Loo]

We do not yet have an openstackclient command that provide the same functionality as 'ironic driver-raid-logical-disk-properties'.

recap: 'ironic driver-raid-logical-disk-properties' returns a table with two columns, the names of properties and their descriptions. If a target RAID config is set for a node, these properties are what can be in the specified RAID config.

Some possibilities:

openstack baremetal driver show --raid-logical-disk-properties
   pro. the RAID properties are part of a driver, so it fits here
   con. the information returned is different that the info returned w/o this option
   Trying to return the driver info AND these properties is ugly because the table would need to
   include both 'types' of information

openstack baremetal driver raid logical disk properties show
   pro. it is clear what it is?
   con. what a mouthful
        Not sure this conforms to openstackclient 'philosophy'. Is a
        'driver raid logical disk properties' an object? All we do
        is display this information; it cannot be manipulated.

After the driver composition reform work is done, the 'driver' will be an interface, eg RAID interface. Maybe thinking about that will help inform our decision. Or maybe not.

[Ruby Loo (rloo)]

I added 'ironic' project too, cuz I think we need to do that for RFEs, even though the coding will be in the client.

[Dmitry Tantsur (divius)]

> I added 'ironic' project too, cuz I think we need to do that for RFEs

Let's fix it if that's the case. I'd prefer to keep our bug tracker clean.

[Galyna Zholtkevych (gzholtkevych)]

As one more proposition I uploaded the patch https://review.openstack.org/#/c/362047/

[Dmitry Tantsur (divius)]

I'd prefer "openstack baremetal driver raid properties show". I'll propose this as a topic on the PTG.

[Ruby Loo (rloo)]

There is a spec patch to address this: https://review.openstack.org/#/c/439907/

[Ruby Loo (rloo)]

Approved spec: http://specs.openstack.org/openstack/ironic-specs/specs/approved/osc-driver-property-commands.html

[Ruby Loo (rloo)]

The command we decided upon (see approved spec) is: openstack baremetal driver raid property list <driver>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/362047
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=befbb7e63e210cc3a47bc044de74d35b19a43ed5
Submitter: Jenkins
Branch: master

commit befbb7e63e210cc3a47bc044de74d35b19a43ed5
Author: Galyna Zholtkevych <email address hidden>
Date: Wed Sep 7 15:00:36 2016 +0300

    Add OSC 'baremetal driver raid property list' cmd

    Extends the OSC plugin with the new command:
      openstack baremetal driver raid property list <driver>
    This returns a list of the names of the driver's RAID
    logical disk properties along with their descriptions.

    Change-Id: Ie4baeb2920a9ab114204ac4aee4a561492ba2741
    Closes-Bug: 1619052
    Co-Authored-By: Ruby Loo <email address hidden>

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/480623

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-ironicclient 1.14.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/480623
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=1375c2ed810a74bb83b195b43c22c808a7c3feb3
Submitter: Jenkins
Branch: master

commit 1375c2ed810a74bb83b195b43c22c808a7c3feb3
Author: Kyrylo Romanenko <email address hidden>
Date: Wed Jul 5 17:37:19 2017 +0300

    Add test for set/unset node target_raid_config

    Change-Id: I4957d06d3fe1a88930d30a4d29a379e18ef37c1d
    Related-Bug: #1619052