[RFE] Implementation of ironic commands as an OSC plugin

[Vladyslav Drok]

The OpenStackClient is becoming the defacto cli client for OpenStack. This spec will spell out what the command structure should look like, including parameters and command names.

[Jim Rollenhagen (jim-rollenhagen)]

Spec is here and is approved: http://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/ironicclient-osc-plugin.html

[aeva black (tenbrae)]

I am marking this as affecting ironic for the purposes of tracking the design specification linked above, even though the change will be completed in the python-ironicclient project. We should mark this bug as released in both projects at the same time when it is done.

[Ruby Loo (rloo)]

Brad, I assigned the 'ironic' part to you so that it doesn't show as unassigned. I don't want someone coming along and assigning it to themself :)

[Ruby Loo (rloo)]

Patches to address this:

  https://review.openstack.org/#/c/284160/
  https://review.openstack.org/#/c/172461/
  https://review.openstack.org/#/c/172517/
  https://review.openstack.org/#/c/206119/
  https://review.openstack.org/#/c/216727/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/284160
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=36b9bfb509959ed4700cf174b76dd4a692cd54c5
Submitter: Jenkins
Branch: master

commit 36b9bfb509959ed4700cf174b76dd4a692cd54c5
Author: Brad P. Crochet <email address hidden>
Date: Wed Jan 20 07:58:16 2016 -0500

    Bring OSC plugin inline with approved spec

    This deprecates the existing commands and replaces them with equivalents
    that follow the approved spec.

    * openstack baremetal create -> openstack baremetal node create
    * openstack baremetal delete -> openstack baremetal node delete
    * openstack baremetal list -> openstack baremetal node list
    * openstack baremetal set -> openstack baremetal node set
    * openstack baremetal show -> openstack baremetal node show
    * openstack baremetal unset -> openstack baremetal node unset

    Delete can handle multiple nodes.

    Change-Id: I2f3e51973d26c968beae96ecf4447f66841f6155
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/172461
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=81d0625401f51b26dc418569971c17b4a5357bbe
Submitter: Jenkins
Branch: master

commit 81d0625401f51b26dc418569971c17b4a5357bbe
Author: Brad P. Crochet <email address hidden>
Date: Fri Apr 10 11:04:40 2015 -0400

    Implementation of baremetal port create

    Change-Id: Ia9fed8f4987cf8ae2ca0a3cb7726596a627cba4f
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/172517
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=df8187ca8190e2ab298b955bc650f94a3ddb35ae
Submitter: Jenkins
Branch: master

commit df8187ca8190e2ab298b955bc650f94a3ddb35ae
Author: Brad P. Crochet <email address hidden>
Date: Fri Apr 10 13:17:05 2015 -0400

    Implementation of baremetal power state commands

    * baremetal node power on|off
    * baremetal node reboot

    Also, renamed baremetal.py to baremetal_node.py to match the command.

    Change-Id: I79b75ecb5dd0b13e74f60f506ff37bda6178271c
    Depends-On: Ia9fed8f4987cf8ae2ca0a3cb7726596a627cba4f
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/206119
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=77e543779fa23d088654d64c932bef5b1c7044dc
Submitter: Jenkins
Branch: master

commit 77e543779fa23d088654d64c932bef5b1c7044dc
Author: Brad P. Crochet <email address hidden>
Date: Thu Jul 23 14:44:45 2015 -0400

    Add provision state commands

    baremetal node abort
    baremetal node clean
    baremetal node deploy
    baremetal node inspect
    baremetal node manage
    baremetal node provide
    baremetal node rebuild
    baremetal node undeploy

    Change-Id: I82f17397c69edc973e79d9c5ae543d9ccbb0325a
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/216727
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=b9b6e93f8023104a72a980d3385fc4bed6acd4d9
Submitter: Jenkins
Branch: master

commit b9b6e93f8023104a72a980d3385fc4bed6acd4d9
Author: Brad P. Crochet <email address hidden>
Date: Mon Aug 24 15:46:12 2015 -0400

    Add maintenance mode commands

    baremetal node maintenance set
    baremetal node maintenance unset

    Change-Id: Idbb451b90dbe8ad6ee410b06a18592ba74d29514
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/344732

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/345815

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/344732
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=db96f3b47a5c5f63b4791b4394a3c422ef5c75d2
Submitter: Jenkins
Branch: master

commit db96f3b47a5c5f63b4791b4394a3c422ef5c75d2
Author: Kyrylo Romanenko <email address hidden>
Date: Wed Jul 20 13:48:14 2016 +0300

    Add baremetal port show command to OSC plugin

    Change-Id: Id43d2fb6b734a8625c3780e1c226d81c7f24ae79
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/350050

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/347402
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=4fdaccd638ef887d075c681344f4fad9c294e525
Submitter: Jenkins
Branch: master

commit 4fdaccd638ef887d075c681344f4fad9c294e525
Author: Kyrylo Romanenko <email address hidden>
Date: Tue Jul 26 13:54:06 2016 +0000

    Add baremetal port unset command to OSC plugin

    Change-Id: Ieedb2639b7c155733dc3d3a1194f4d889e2c7e52
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/356671

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/356759

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/357400

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/347287
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=3a4f3af948a6a6ed3f3899bd76d9f1b652937272
Submitter: Jenkins
Branch: master

commit 3a4f3af948a6a6ed3f3899bd76d9f1b652937272
Author: Kyrylo Romanenko <email address hidden>
Date: Tue Jul 26 11:48:46 2016 +0000

    Add baremetal port set command to OSC plugin

    Change-Id: I4598ab5168a3755e8c61f9cb1c352e66cd2b647b
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/359322

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/356671
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=eb8d9e84809c146459b972bb258a979d52903217
Submitter: Jenkins
Branch: master

commit eb8d9e84809c146459b972bb258a979d52903217
Author: Ruby Loo <email address hidden>
Date: Wed Aug 17 15:13:34 2016 -0400

    Add 'openstack baremetal node adopt' command

    This extends the OpenStackClient plugin with the new command
    'openstack baremetal node adopt'. The command sets a node's
    provision state to 'adopt'.

    Change-Id: Ib41e1c66378df7db2e5396b940930a9f7e009977
    Partial-Bug: 1526479

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/360787

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/346075
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=7513aae7e23fb76766afb69949a5a93503852e72
Submitter: Jenkins
Branch: master

commit 7513aae7e23fb76766afb69949a5a93503852e72
Author: Rodion Promyshlennikov <email address hidden>
Date: Thu Aug 25 20:34:00 2016 +0300

    Add baremetal port delete command to OSC plugin

    Change-Id: I4d08ebf38fda739840a1bb98c0bc5bf2ff769b65
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/356759
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=fd54fd076f13565850546daf4c209a0c6994a782
Submitter: Jenkins
Branch: master

commit fd54fd076f13565850546daf4c209a0c6994a782
Author: Ruby Loo <email address hidden>
Date: Wed Aug 17 17:50:19 2016 -0400

    Adds 'openstack baremetal node console' commands

    Adds the following console-related commands to the
    OpenStackClient plugin:
        openstack baremetal node console disable
        openstack baremetal node console enable
        openstack baremetal node console show

    Change-Id: I060531baf84907cdf3763369a43469ec1c860e4d
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/346722
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=1add122169c1b1beef61813e588c88ada7b7ca90
Submitter: Jenkins
Branch: master

commit 1add122169c1b1beef61813e588c88ada7b7ca90
Author: Rodion Promyshlennikov <email address hidden>
Date: Fri Aug 26 10:47:42 2016 +0300

    Add baremetal port list command to OSC plugin

    Partial-Bug: #1526479
    Change-Id: Ibfba276c3f4c0c090c48897716aaf4fb193370b0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/362445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/345815
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=dd755102e86f10b5df26d3b7a56dfe68a9581b1f
Submitter: Jenkins
Branch: master

commit dd755102e86f10b5df26d3b7a56dfe68a9581b1f
Author: Ruby Loo <email address hidden>
Date: Fri Jul 22 01:28:52 2016 -0400

    Add openstack baremetal chassis commands

    This extends the OpenStackClient plugin with new commands related
    to the chassis:

      * openstack baremetal chassis create
      * openstack baremetal chassis delete
      * openstack baremetal chassis list
      * openstack baremetal chassis set
      * openstack baremetal chassis show
      * openstack baremetal chassis unset

    Change-Id: I6a655b9f136d0214b6e9bb868f411ba948557ac3
    Partial-Bug: 1526479

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/362515

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/360787
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=1688aed145b5f8a6f4746355db964a1f926b39ff
Submitter: Jenkins
Branch: master

commit 1688aed145b5f8a6f4746355db964a1f926b39ff
Author: Ruby Loo <email address hidden>
Date: Thu Aug 25 16:59:06 2016 -0400

    Set/unset node's target RAID config via OSC command

    Allows setting and unsetting (clearing) the node's target
    RAID configuration via the OpenStackClient plugin commands
    'openstack baremetal node set --target-raid-config' and
    'openstack baremetal node unset --target-raid-config'
    respectively.

    Change-Id: I5ee61aec4d110a84d50347fa10b7c16fc2fda353
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/362445
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=188ab8c3acba56a6c80b06b9de057c2991c14f1b
Submitter: Jenkins
Branch: master

commit 188ab8c3acba56a6c80b06b9de057c2991c14f1b
Author: Ruby Loo <email address hidden>
Date: Mon Aug 29 16:56:06 2016 -0400

    Add --node to 'openstack baremetal port list'

    This adds an optional '--node' (name or UUID of a node) to the
    'openstack baremetal port list' command. It provides the ability
    to get a list of ports of a specified node.

    The existing release note covers this:
    releasenotes/notes/osc-plugin-7769f5bef627654c.yaml.

    Change-Id: Ic7064dafe061c9f751ffe0da99ede609c46c9255
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/357400
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=0f005338e9a166412eba1fb010eb5063d63dc5ef
Submitter: Jenkins
Branch: master

commit 0f005338e9a166412eba1fb010eb5063d63dc5ef
Author: Ruby Loo <email address hidden>
Date: Thu Aug 18 14:09:05 2016 -0400

    Adds node boot device & passthru OSC commands

    Adds the following node boot device and node passthru commands
    to the OpenStackClient plugin:
      - openstack baremetal node boot device set
      - openstack baremetal node boot device show
      - openstack baremetal node passthru call
      - openstack baremetal node passthru list

    Change-Id: I803bf263c0e548019425e769f1d3ae5ae33d9940
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/362515
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=1345372cb3585689d11f788156ec1bfda28183c4
Submitter: Jenkins
Branch: master

commit 1345372cb3585689d11f788156ec1bfda28183c4
Author: Ruby Loo <email address hidden>
Date: Mon Aug 29 21:13:31 2016 -0400

    Add --chassis to 'openstack baremetal node list'

    This adds an optional '--chassis <chassis UUID>' to the
    'openstack baremetal node list' command. It provides
    the ability to get a list of nodes of a specified chassis.

    Change-Id: I5dbc0521858823d2e83506b6f873eda9a143f80b
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/359322
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=d8cd1ce54bdd27146cdf9918b06abf52a9b57bd9
Submitter: Jenkins
Branch: master

commit d8cd1ce54bdd27146cdf9918b06abf52a9b57bd9
Author: Ruby Loo <email address hidden>
Date: Tue Aug 23 12:15:18 2016 -0400

    Add node validate OSC command

    Adds 'openstack baremetal node validate' command to the OpenStackClient
    plugin.

    Change-Id: I53c0f949f2c0f2c353c40b3333669ed64c1062c4
    Partial-Bug: #1526479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/350050
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=e31544bf5d014b87a3b8585e3d27c4f81a591ce3
Submitter: Jenkins
Branch: master

commit e31544bf5d014b87a3b8585e3d27c4f81a591ce3
Author: Rodion Promyshlennikov <email address hidden>
Date: Mon Aug 29 19:44:35 2016 +0300

    Add openstack baremetal driver commands

    Extends the OSC plugin with new commands related
    to the drivers:
      * openstack baremetal driver list
      * openstack baremetal driver passthru call
      * openstack baremetal driver passthru list
      * openstack baremetal driver show

    Change-Id: I68ae82d1ff7e2944c1d04f86c4362b6c0f499df1
    Partial-Bug: 1526479
    Co-Authored-By: Ruby Loo <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/363921

[Dmitry Tantsur (divius)]

Seems like we can call it done; we have other RFEs for missing bits.