ironic *-show commands return empty properties when the input uuid is "" or space char

[Haomeng,Wang]

ironic *-show commands return empty properties when the input uuid is "" or space char as below behavior:

[root@rhel7-osee ironic]# ironic chassis-show ""

+-------------+-------+
| Property | Value |
+-------------+-------+
| updated_at | |
| created_at | |
| extra | |
| uuid | |
| description | |
+-------------+-------+

[root@rhel7-osee ironic]#

[root@rhel7-osee ironic]# ironic port-show ""

+------------+-------+
| Property | Value |
+------------+-------+
| node_uuid | |
| uuid | |
| extra | |
| created_at | |
| updated_at | |
| address | |
+------------+-------+
[root@rhel7-osee ironic]#

[Haomeng,Wang (whaom)]

Share the current behavior without debug information as below:

[root@rhel7-osee ironic]# ironic chassis-show ""

+-------------+-------+
| Property | Value |
+-------------+-------+
| updated_at | |
| created_at | |
| extra | |
| uuid | |
| description | |
+-------------+-------+

[root@rhel7-osee ironic]#

[root@rhel7-osee ironic]# ironic port-show ""

+------------+-------+
| Property | Value |
+------------+-------+
| node_uuid | |
| uuid | |
| extra | |
| created_at | |
| updated_at | |
| address | |
+------------+-------+
[root@rhel7-osee ironic]#

[Ruby Loo (rloo)]

Hi, if you add --debug, you'll see the API call that is made.

for ironic chassis-show "": http://localhost:6385/v1/chassis

Without a chassis uuid in the url, this is basically a chassis-list call.

[Haomeng,Wang (whaom)]

Ruby, yes, agree with you, it is fine for API level, so we just add validation from client code to check if uuid is empty or space chars and prompt to user.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/172618
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=cec37d5a67b2500263e033b7241606174513a38f
Submitter: Jenkins
Branch: master

commit cec37d5a67b2500263e033b7241606174513a38f
Author: Haomeng, Wang <email address hidden>
Date: Sat Apr 18 11:30:55 2015 +0000

    Ensure *-show input uuid is not empty

    Ironic *-show does not ensure that uuid are not empty.

    This patch adds checks to the client to ensure that command line
    arguments are not empty strings or only whitespace. It will raise
    a command exception if *-show command line argument is an empty
    string or only whitespace.

    Change-Id: Ia34957922006da5ecbbfc7483040d67ac51f0ada
    Closes-Bug: 1442436

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/177989

[aeva black (tenbrae)]

Removing tag kilo-rc-potential as this is not related to client library dependencies.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Haomeng,Wang (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/177989