don't resolve outputs immediately after "stack create"

Bug #1659899 reported by Crag Wolfe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-heatclient
Fix Released
Undecided
Crag Wolfe

Bug Description

When doing an "openstack stack create" or "openstack stack update" without --wait, an api call to show the stack with resolved outputs is made immediately afterwards. In the overwhelming majority of cases, attempting to resolve the outputs so quickly is just a waste of time and processing. Let's not do that in this case.

Crag Wolfe (cwolfe)
Changed in python-heatclient:
assignee: nobody → Crag Wolfe (cwolfe)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/426478

Changed in python-heatclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/426478
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=c1e793f3b81403d32d665679001264716aa38505
Submitter: Jenkins
Branch: master

commit c1e793f3b81403d32d665679001264716aa38505
Author: Crag Wolfe <email address hidden>
Date: Sat Jan 28 00:37:47 2017 -0500

    Don't always resolve outputs when showing a stack

    * Whenever a stack is created/updated/adopted, a call to show the
      stack is made. Do not resolve the outputs when showing the stack in
      this case because:

      * If we are not waiting (there is no --wait arg) for the stack to
        complete after a create/update/adopt command and immediately
        showing the stack, resolving the outputs is just incurring a
        pointless processing hit on the server (ultimately heat-engine)
        and delaying a response to the client.

      * Whether we --wait or or not, we only show "short" stack info which
        doesn't include outputs anyway. So, let's avoid the
        processing/time overhead of resolving the outputs. (In theory,
        with --wait we might want to show "long" output with stack outputs
        afterwards, but that would be additional functionality that should
        be handled in a different patch)

    * Add the --no-resolve-outputs option to "stack show" which already
      exists in the legacy heat stack-show command.

    Change-Id: Id0661b11fd3cece0df3981488de6976219556d7e
    Closes-Bug: #1659896
    Closes-Bug: #1659899

Changed in python-heatclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-heatclient 1.9.0

This issue was fixed in the openstack/python-heatclient 1.9.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.