Invalid error message when wrong orchestration sub command is given

[Kanagaraj Manickam]

When the wrong sub command is given as below (tempalte is given with spell mistake), error message reports "openstack: 'orchestration' is not an openstack command". But this should be reported with mentioning that 'tempalte' command is invalid"

More details below

manickan@mrkanag-os:~/workspace/hot-tutorials$ openstack orchestration tempalte validate -t hello-world-1.yaml
openstack: 'orchestration' is not an openstack command. See 'openstack --help'.
Did you mean one of these?
  orchestration build info
  orchestration resource type list
  orchestration resource type show
  orchestration service list
  orchestration template function list
  orchestration template validate
  orchestration template version list
  configuration show
manickan@mrkanag-os:~/workspace/hot-tutorials$ openstack orchestration template validate -t hello-world-1.yaml
Description: First heat hot template used to demonstrate the hot template sections.
Parameters: {}
manickan@mrkanag-os:/opt/stack/python-heatclient$ git status
On branch master
Your branch is up-to-date with 'origin/master'.

nothing to commit, working directory clean
manickan@mrkanag-os:/opt/stack/python-heatclient$

[Ali Jabbar (jabbar-ali)]

I am assigning this bug to me.

[Jaspreet Singh Rawel (jaspreetsinghrawel)]

Reproduced using devstack on mitaka branch.

[Ali Jabbar (jabbar-ali)]

Problem reproduced
stack@cinv-V:/home/cinv/devstack$ openstack orchestration tempalte validate -t hello-world-1.yaml
openstack: 'orchestration' is not an openstack command. See 'openstack --help'.
Did you mean one of these?
  orchestration build info
  orchestration resource type list
  orchestration resource type show
  orchestration service list
  orchestration template function list
  orchestration template version list
  configuration show
stack@cinv-V:/home/cinv/devstack$

[Rabi Mishra (rabi)]

I think this is an openstackclient issue instead. Any other command will have the similar message. If you try:

#openstack server xxx

openstack: 'server' is not an openstack command. See 'openstack --help'.
Did you mean one of these?
  server add fixed ip
  server add floating ip
  server add security group
  server add volume
  server backup create
....

[Ali Jabbar (jabbar-ali)]

We found that root cause of this issue in the cliff code :
https://bugs.launchpad.net/python-cliff/+bug/1640031

cliff/app.py

def run_subcommand( ,)
 >>> Here it is printing argv[0] in every case.

[Ali Jabbar (jabbar-ali)]

Path for this issue
https://review.openstack.org/#/c/394884/

[Ali Jabbar (jabbar-ali)]

https://review.openstack.org/#/c/394884/

----------------
self.stdout.write('%s: \'%s\' is not %s %s command. '
                                  'See \'%s --help\'.\n'
                                  % (self.NAME, ' '.join(argv), article,
                                      self.NAME, self.NAME))
self.stdout.write('Did you mean one of these?\n')