Uninformative yaml error during parsing template

[Peter Razumovsky]

Step
1 ssh to one of controllers

2 execute: . openrc

3 create stack using aws format template:
heat stack-create --template-url https://github.com/openstack/heat-templates/blob/master/cfn/F17/Neutron_floating.template -P internal_network=<id> -P external_network=<id> -P internal_subnet=<id>

Where <id> your existing networks

Result:
Error parsing template https://github.com/openstack/heat-templates/blob/master/cfn/F17/Neutron_floating.template mapping values are not allowed in this context
  in "<unicode string>", line 6, column 19

But when we change template format ( Raw view on GitHub) command works correctly
( https://raw.githubusercontent.com/openstack/heat-templates/master/cfn/F17/Neutron_floating.template )

We need to provide more recognizable error message or try to say, that template is wrong due to ...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/232565

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/232565
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=54a1715e348720ab31b5d2e38035bf429471cdbe
Submitter: Jenkins
Branch: master

commit 54a1715e348720ab31b5d2e38035bf429471cdbe
Author: Peter Razumovsky <email address hidden>
Date: Thu Oct 8 17:22:59 2015 +0300

    Add option for detailed template error

    Add option detailed_template_error for informative
    error during template and environment parsing.

    yaml.SafeLoader returns error with template snippet where
    error has been occurred instead of CSafeLoader. But
    CSafeLoader is faster. So, if user wants to get more
    informative error, use slower but more detailed SafeLoader
    for yaml loading.

    Change-Id: Ied0a573a00eb5f564dea0c636da1301de5de9ea7
    Closes-bug: #1496361

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/235449

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/liberty
Review: https://review.openstack.org/235450

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/235451

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235449
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b41739a63ed915a763d9102865056ee540477917
Submitter: Jenkins
Branch: master

commit b41739a63ed915a763d9102865056ee540477917
Author: Peter Razumovsky <email address hidden>
Date: Thu Oct 15 18:43:27 2015 +0300

    Add more informative error during parsing

    If there is some error during parsing template or
    env file, CSafeLoader errors doesn't contains snippet
    from template. So, we need to use SafeLoader for more
    informative error with snippet from parsed template.

    Change-Id: I79039164533c032db66c933c4e8882b8942961eb
    Related-bug: #1496361

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235450
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=764ec45bea76ce1983dc2eb4dd3a3c306b58de8b
Submitter: Jenkins
Branch: stable/liberty

commit 764ec45bea76ce1983dc2eb4dd3a3c306b58de8b
Author: Peter Razumovsky <email address hidden>
Date: Thu Oct 15 18:43:27 2015 +0300

    Add more informative error during parsing

    If there is some error during parsing template or
    env file, CSafeLoader errors doesn't contains snippet
    from template. So, we need to use SafeLoader for more
    informative error with snippet from parsed template.

    Change-Id: I79039164533c032db66c933c4e8882b8942961eb
    Related-bug: #1496361
    (cherry picked from commit b41739a63ed915a763d9102865056ee540477917)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235451
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=d812114ec08b70e840a7de5dd5116759a1dce41e
Submitter: Jenkins
Branch: stable/liberty

commit d812114ec08b70e840a7de5dd5116759a1dce41e
Author: Peter Razumovsky <email address hidden>
Date: Thu Oct 8 17:22:59 2015 +0300

    Add option for detailed template error

    NOTE: The title of original patch is incorrect, because
    patch adds additional yaml parsing with detailed error,
    but there's no adding new option for this.

    If there is some error during parsing template or
    env file, CSafeLoader errors doesn't contains snippet
    from template. So, we need to use SafeLoader for more
    informative error with snippet from parsed template.

    Change-Id: Ied0a573a00eb5f564dea0c636da1301de5de9ea7
    Closes-bug: #1496361
    (cherry picked from commit 54a1715e348720ab31b5d2e38035bf429471cdbe)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-heatclient 0.8.1 release.